You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Alexei Zakharov <al...@gmail.com> on 2008/02/12 16:08:37 UTC

Re: svn commit: r612718 [1/2] - in /harmony/enhanced/classlib/trunk: modules/luni/make/ modules/luni/src/main/java/java/util/ modules/luni/src/main/java/org/apache/harmony/luni/internal/locale/ modules/luni/src/test/api/common/org/apache/harmony/luni

Tony, all,

I like to inform you that our Struts scenario constantly fails - see
[1] - after you moved DateFormat related classes to ICU-based
implementation at r612718. Please see details in HARMONY-5498 I posted
recently. I do not suggest to roll-back this commit. However, I like
to hear what other people think about it.

[1] http://people.apache.org/~smishura/r620256/Windows_x86/struts_test/

Thanks,
Alexei

2008/1/17, tonywu@apache.org <to...@apache.org>:
> Author: tonywu
> Date: Wed Jan 16 21:42:17 2008
> New Revision: 612718
>
> URL: http://svn.apache.org/viewvc?rev=612718&view=rev
> Log:
> remove locate data, delegate related classes to ICU
>
> Removed:
>     harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/internal/locale/
> Modified:
>     harmony/enhanced/classlib/trunk/modules/luni/make/exclude.common
>     harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Calendar.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Currency.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Locale.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/SimpleTimeZone.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/TimeZone.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/DateTest.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/GregorianCalendarTest.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/SimpleTimeZoneTest.java
>     harmony/enhanced/classlib/trunk/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/TimeZoneTest.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/DateFormat.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/DateFormatSymbols.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/DecimalFormat.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/DecimalFormatSymbols.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/Format.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/MessageFormat.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/NumberFormat.java
>     harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/text/SimpleDateFormat.java
>     harmony/enhanced/classlib/trunk/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/CollationElementIteratorTest.java
>     harmony/enhanced/classlib/trunk/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/DateFormatSymbolsTest.java
>     harmony/enhanced/classlib/trunk/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/DecimalFormatSymbolsTest.java
>     harmony/enhanced/classlib/trunk/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/MessageFormatTest.java
>     harmony/enhanced/classlib/trunk/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/NumberFormatTest.java
>     harmony/enhanced/classlib/trunk/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/RuleBasedCollatorTest.java
>     harmony/enhanced/classlib/trunk/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/SimpleDateFormatTest.java
>     harmony/enhanced/classlib/trunk/support/src/test/java/tests/support/Support_SimpleDateFormat.java
>
> Modified: harmony/enhanced/classlib/trunk/modules/luni/make/exclude.common
> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/make/exclude.common?rev=612718&r1=612717&r2=612718&view=diff

[classlib][text] DateFormatSymbols (was: Re: svn commit: r612718 [1/2] - in /harmony/enhanced/classlib/trunk: modules/luni/make/ modules/luni/src/main/java/java/util/ modules/luni/src/main/java/org/apache/harmony/luni/internal/locale/ modules/luni/src/test/api/common/org/apache/harmony/luni)

Posted by Tim Ellison <t....@gmail.com>.
Alexei Zakharov wrote:
> Tony, all,
> 
> I like to inform you that our Struts scenario constantly fails - see
> [1] - after you moved DateFormat related classes to ICU-based
> implementation at r612718. Please see details in HARMONY-5498 I posted
> recently. I do not suggest to roll-back this commit. However, I like
> to hear what other people think about it.
> 
> [1] http://people.apache.org/~smishura/r620256/Windows_x86/struts_test/

Hmm, that seems like strange behavior to me -- there is no month called "".

Is the empty string present for other locales too, or just English?

Regards,
Tim