You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2007/07/31 00:31:14 UTC
spacer.gif in editorderitems.ftl
Hi,
I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
Jacques
Re: spacer.gif in editorderitems.ftl
Posted by Adrian Crum <ad...@hlmksw.com>.
Those were used to position things in table-based layout. The same thing can be accomplished with
CSS now.
Jacques Le Roux wrote:
> Hi,
>
> I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
>
> Jacques
>
Re: spacer.gif in editorderitems.ftl
Posted by Ray Barlow <ra...@makeyour-point.com>.
Oddly enough I just did that a few minutes ago and it does work. The
update and delete 'button' are a little different in size but the return
key does at least work without the gif entry.
I've also been through and finished correcting the invalid table
structures so I'll commit it shortly.
Ray
Adrian Crum wrote:
> Jacques,
>
> Try changing the Update link (<a> element) to an <input> element:
>
> <td nowrap width="25%">
> <input type="text" name="amount" size="6" value="<@ofbizAmount
> amount=adjustmentAmount/>"/>
> <input type="submit" value="${uiLabelMap.CommonUpdate}"/>
> <a
> href="<@o...@ofbizUrl>"
> class="buttontext">${uiLabelMap.CommonDelete}</a>
> </td>
>
> -Adrian
>
>
Re: spacer.gif in editorderitems.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
+1
Jacques
De : "Jacopo Cappellato" <ti...@sastau.it>
> Yes,
>
> and most of the ftl files (and bsh scripts) could also disappear by
> converting them to the widgets.
>
> Jacopo
>
> Adrian Crum wrote:
> > Ray,
> >
> > Thank you very much for all your effort!
> >
> > I understand what you mean when you say cleaning up HTML is a pain. I
> > just spent most of last Saturday cleaning up a bunch of ftl files, and
> > even then there was still more work to do on them.
> >
> > -Adrian
> >
> > Ray Barlow wrote:
> >
> >> I also just noticed the delete button fails anyway with an error:
> >> The following required parameter is missing: [resetGrandTotal.orderId]
> >>
> >> It's not related to these changes as the test server fails also, job for
> >> another day.
> >>
> >> Ray
> >>
> >>
> >> Adrian Crum wrote:
> >>
> >>> Jacques,
> >>>
> >>> Try changing the Update link (<a> element) to an <input> element:
> >>>
> >>> <td nowrap width="25%">
> >>> <input type="text" name="amount" size="6" value="<@ofbizAmount
> >>> amount=adjustmentAmount/>"/>
> >>> <input type="submit" value="${uiLabelMap.CommonUpdate}"/>
> >>> <a
> >>>
href="<@o...@ofbizUrl>
"
> >>>
> >>> class="buttontext">${uiLabelMap.CommonDelete}</a>
> >>> </td>
> >>>
> >>> -Adrian
> >>>
> >>
> >>
Re: spacer.gif in editorderitems.ftl
Posted by Jacopo Cappellato <ti...@sastau.it>.
Yes,
and most of the ftl files (and bsh scripts) could also disappear by
converting them to the widgets.
Jacopo
Adrian Crum wrote:
> Ray,
>
> Thank you very much for all your effort!
>
> I understand what you mean when you say cleaning up HTML is a pain. I
> just spent most of last Saturday cleaning up a bunch of ftl files, and
> even then there was still more work to do on them.
>
> -Adrian
>
> Ray Barlow wrote:
>
>> I also just noticed the delete button fails anyway with an error:
>> The following required parameter is missing: [resetGrandTotal.orderId]
>>
>> It's not related to these changes as the test server fails also, job for
>> another day.
>>
>> Ray
>>
>>
>> Adrian Crum wrote:
>>
>>> Jacques,
>>>
>>> Try changing the Update link (<a> element) to an <input> element:
>>>
>>> <td nowrap width="25%">
>>> <input type="text" name="amount" size="6" value="<@ofbizAmount
>>> amount=adjustmentAmount/>"/>
>>> <input type="submit" value="${uiLabelMap.CommonUpdate}"/>
>>> <a
>>> href="<@o...@ofbizUrl>"
>>>
>>> class="buttontext">${uiLabelMap.CommonDelete}</a>
>>> </td>
>>>
>>> -Adrian
>>>
>>
>>
Re: spacer.gif in editorderitems.ftl
Posted by Adrian Crum <ad...@hlmksw.com>.
Ray,
Thank you very much for all your effort!
I understand what you mean when you say cleaning up HTML is a pain. I just spent most of last
Saturday cleaning up a bunch of ftl files, and even then there was still more work to do on them.
-Adrian
Ray Barlow wrote:
> I also just noticed the delete button fails anyway with an error:
> The following required parameter is missing: [resetGrandTotal.orderId]
>
> It's not related to these changes as the test server fails also, job for
> another day.
>
> Ray
>
>
> Adrian Crum wrote:
>
>>Jacques,
>>
>>Try changing the Update link (<a> element) to an <input> element:
>>
>><td nowrap width="25%">
>><input type="text" name="amount" size="6" value="<@ofbizAmount
>>amount=adjustmentAmount/>"/>
>><input type="submit" value="${uiLabelMap.CommonUpdate}"/>
>><a
>>href="<@o...@ofbizUrl>"
>>class="buttontext">${uiLabelMap.CommonDelete}</a>
>></td>
>>
>>-Adrian
>>
>
>
Re: spacer.gif in editorderitems.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Adrian and Ray,
Later I will have a look to see if there are more of this kind....
Jacques
De : "Ray Barlow" <ra...@makeyour-point.com>
> I also just noticed the delete button fails anyway with an error:
> The following required parameter is missing: [resetGrandTotal.orderId]
>
> It's not related to these changes as the test server fails also, job for
> another day.
>
> Ray
>
>
> Adrian Crum wrote:
> > Jacques,
> >
> > Try changing the Update link (<a> element) to an <input> element:
> >
> > <td nowrap width="25%">
> > <input type="text" name="amount" size="6" value="<@ofbizAmount
> > amount=adjustmentAmount/>"/>
> > <input type="submit" value="${uiLabelMap.CommonUpdate}"/>
> > <a
> >
href="<@o...@ofbizUrl>
"
> > class="buttontext">${uiLabelMap.CommonDelete}</a>
> > </td>
> >
> > -Adrian
> >
Re: spacer.gif in editorderitems.ftl
Posted by Ray Barlow <ra...@makeyour-point.com>.
I also just noticed the delete button fails anyway with an error:
The following required parameter is missing: [resetGrandTotal.orderId]
It's not related to these changes as the test server fails also, job for
another day.
Ray
Adrian Crum wrote:
> Jacques,
>
> Try changing the Update link (<a> element) to an <input> element:
>
> <td nowrap width="25%">
> <input type="text" name="amount" size="6" value="<@ofbizAmount
> amount=adjustmentAmount/>"/>
> <input type="submit" value="${uiLabelMap.CommonUpdate}"/>
> <a
> href="<@o...@ofbizUrl>"
> class="buttontext">${uiLabelMap.CommonDelete}</a>
> </td>
>
> -Adrian
>
Re: spacer.gif in editorderitems.ftl
Posted by Adrian Crum <ad...@hlmksw.com>.
Jacques,
Try changing the Update link (<a> element) to an <input> element:
<td nowrap width="25%">
<input type="text" name="amount" size="6" value="<@ofbizAmount amount=adjustmentAmount/>"/>
<input type="submit" value="${uiLabelMap.CommonUpdate}"/>
<a
href="<@o...@ofbizUrl>"
class="buttontext">${uiLabelMap.CommonDelete}</a>
</td>
-Adrian
Jacques Le Roux wrote:
> Adrian,
>
> Try to remove it and you will not be able to use enter to update the field as it is doing now. I akcnowledege that it's weird but it
> works. No other comments ?
>
> Jacques
>
> De : "Adrian Crum" <ad...@hlmksw.com>
>
>>If there is an Update button that performs the same action as the spacer.gif, then the spacer.gif is
>>not needed.
>>
>>
>>Jacques Le Roux wrote:
>>
>>
>>>Yes but this will be redundant with the update button and you can't have 2 submit buttons (there is also the delete button). So
>
> this
>
>>>acts as a default button (for update).
>>>
>>>I'm sure there are other solutions, but It's too late here...
>>>
>>>Jacques
>>>
>>>De : "Adrian Crum" <ad...@hlmksw.com>
>>>
>>>>It would be better to have an actual (visible) Submit button - for accessibility reasons.
>>>>
>>>>
>>>>Jacques Le Roux wrote:
>>>>
>>>>
>>>>
>>>>>Ho, I see it's to allow (simulate) a submit button
>>>>>
>>>>>Jacques
>>>>>
>>>>>De : "Jacques Le Roux" <ja...@les7arts.com>
>>>>>
>>>>>>Hi,
>>>>>>
>>>>>>I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
>>>>>>
>>>>>>Jacques
>>>>>>
>>>>>
>>>>>
>>>
>
>
Re: spacer.gif in editorderitems.ftl
Posted by Ray Barlow <ra...@makeyour-point.com>.
Hi,
Nothing obvious looks out of place. I did some cleaning up as there were
plenty of HTML errors and still a few table errors in there I think, but
I need to go out now so have committed the clean ups and may do some
more another day.
It always helps to clean errors from HTML if it doesn't appear to be
working as expected, but generally it's just a pain!
Ray
Jacques Le Roux wrote:
> Adrian,
>
> Try to remove it and you will not be able to use enter to update the field as it is doing now. I akcnowledege that it's weird but it
> works. No other comments ?
>
> Jacques
>
> De : "Adrian Crum" <ad...@hlmksw.com>
>
>> If there is an Update button that performs the same action as the spacer.gif, then the spacer.gif is
>> not needed.
>>
>>
>> Jacques Le Roux wrote:
>>
>>
>>> Yes but this will be redundant with the update button and you can't have 2 submit buttons (there is also the delete button). So
>>>
> this
>
>>> acts as a default button (for update).
>>>
>>> I'm sure there are other solutions, but It's too late here...
>>>
>>> Jacques
>>>
>>> De : "Adrian Crum" <ad...@hlmksw.com>
>>>
>>>
>>>> It would be better to have an actual (visible) Submit button - for accessibility reasons.
>>>>
>>>>
>>>> Jacques Le Roux wrote:
>>>>
>>>>
>>>>
>>>>> Ho, I see it's to allow (simulate) a submit button
>>>>>
>>>>> Jacques
>>>>>
>>>>> De : "Jacques Le Roux" <ja...@les7arts.com>
>>>>>
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>
>>>
>
>
>
Re: spacer.gif in editorderitems.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
Adrian,
Try to remove it and you will not be able to use enter to update the field as it is doing now. I akcnowledege that it's weird but it
works. No other comments ?
Jacques
De : "Adrian Crum" <ad...@hlmksw.com>
> If there is an Update button that performs the same action as the spacer.gif, then the spacer.gif is
> not needed.
>
>
> Jacques Le Roux wrote:
>
> > Yes but this will be redundant with the update button and you can't have 2 submit buttons (there is also the delete button). So
this
> > acts as a default button (for update).
> >
> > I'm sure there are other solutions, but It's too late here...
> >
> > Jacques
> >
> > De : "Adrian Crum" <ad...@hlmksw.com>
> >
> >>It would be better to have an actual (visible) Submit button - for accessibility reasons.
> >>
> >>
> >>Jacques Le Roux wrote:
> >>
> >>
> >>>Ho, I see it's to allow (simulate) a submit button
> >>>
> >>>Jacques
> >>>
> >>>De : "Jacques Le Roux" <ja...@les7arts.com>
> >>>
> >>>>Hi,
> >>>>
> >>>>I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
> >>>>
> >>>>Jacques
> >>>>
> >>>
> >>>
> >
> >
Re: spacer.gif in editorderitems.ftl
Posted by Adrian Crum <ad...@hlmksw.com>.
If there is an Update button that performs the same action as the spacer.gif, then the spacer.gif is
not needed.
Jacques Le Roux wrote:
> Yes but this will be redundant with the update button and you can't have 2 submit buttons (there is also the delete button). So this
> acts as a default button (for update).
>
> I'm sure there are other solutions, but It's too late here...
>
> Jacques
>
> De : "Adrian Crum" <ad...@hlmksw.com>
>
>>It would be better to have an actual (visible) Submit button - for accessibility reasons.
>>
>>
>>Jacques Le Roux wrote:
>>
>>
>>>Ho, I see it's to allow (simulate) a submit button
>>>
>>>Jacques
>>>
>>>De : "Jacques Le Roux" <ja...@les7arts.com>
>>>
>>>>Hi,
>>>>
>>>>I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
>>>>
>>>>Jacques
>>>>
>>>
>>>
>
>
Re: spacer.gif in editorderitems.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes but this will be redundant with the update button and you can't have 2 submit buttons (there is also the delete button). So this
acts as a default button (for update).
I'm sure there are other solutions, but It's too late here...
Jacques
De : "Adrian Crum" <ad...@hlmksw.com>
> It would be better to have an actual (visible) Submit button - for accessibility reasons.
>
>
> Jacques Le Roux wrote:
>
> > Ho, I see it's to allow (simulate) a submit button
> >
> > Jacques
> >
> > De : "Jacques Le Roux" <ja...@les7arts.com>
> >
> >>Hi,
> >>
> >>I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
> >>
> >>Jacques
> >>
> >
> >
Re: spacer.gif in editorderitems.ftl
Posted by Adrian Crum <ad...@hlmksw.com>.
It would be better to have an actual (visible) Submit button - for accessibility reasons.
Jacques Le Roux wrote:
> Ho, I see it's to allow (simulate) a submit button
>
> Jacques
>
> De : "Jacques Le Roux" <ja...@les7arts.com>
>
>>Hi,
>>
>>I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
>>
>>Jacques
>>
>
>
Re: spacer.gif in editorderitems.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
Ho, I see it's to allow (simulate) a submit button
Jacques
De : "Jacques Le Roux" <ja...@les7arts.com>
> Hi,
>
> I wonder if the line containing spacer.gif is usefull or a forgotten scrap ?
>
> Jacques
>