You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/24 11:34:02 UTC
[GitHub] [camel] bjornomy opened a new pull request #7261: [CAMEL-17844] Handle FunctionalInterface (lambas) in BeanInfo
bjornomy opened a new pull request #7261:
URL: https://github.com/apache/camel/pull/7261
This PR aims to fix a regression regarding FunctionalInterfaces in BeanInfo.
* let BeanInfo ignore methods from synthetic classes (proxies and lambdas) when choosing what method to call on a bean
* remove BeanInfoTypeResolver, as it's not longer necesary
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus closed pull request #7261: [CAMEL-17844] Handle FunctionalInterface (lambas) in BeanInfo
Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #7261:
URL: https://github.com/apache/camel/pull/7261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7261: [CAMEL-17844] Handle FunctionalInterface (lambas) in BeanInfo
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7261:
URL: https://github.com/apache/camel/pull/7261#issuecomment-1078802861
Thanks for the PR I have merged it manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #7261: [CAMEL-17844] Handle FunctionalInterface (lambas) in BeanInfo
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #7261:
URL: https://github.com/apache/camel/pull/7261#issuecomment-1077531594
> Is there a way to automatically format the source in such a way that `sourcecheck` passes?
If you run a full build the code will autoformat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7261: [CAMEL-17844] Handle FunctionalInterface (lambas) in BeanInfo
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7261:
URL: https://github.com/apache/camel/pull/7261#issuecomment-1077571011
Also need to test that camel-karaf would still work, as it has special case for beans, the interface that was deleted was in use by camel-karaf, so we need to update its source code also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bjornomy commented on pull request #7261: [CAMEL-17844] Handle FunctionalInterface (lambas) in BeanInfo
Posted by GitBox <gi...@apache.org>.
bjornomy commented on pull request #7261:
URL: https://github.com/apache/camel/pull/7261#issuecomment-1077530755
Is there a way to automatically format the source in such a way that `sourcecheck` passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7261: [CAMEL-17844] Handle FunctionalInterface (lambas) in BeanInfo
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7261:
URL: https://github.com/apache/camel/pull/7261#issuecomment-1078784829
Your changed with checking for synthetic later could potentially make no need for the camel-bean-osgi module which we then can remove - I am testing this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org