You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/29 03:53:08 UTC

[GitHub] [doris] HappenLee commented on a diff in pull request #12118: [fix](storage) storage should aggregate on replace column

HappenLee commented on code in PR #12118:
URL: https://github.com/apache/doris/pull/12118#discussion_r956873433


##########
be/src/exec/olap_scanner.cpp:
##########
@@ -291,20 +292,23 @@ Status OlapScanner::_init_return_columns(bool need_seq_col) {
         _query_slots.push_back(slot);
     }
 
-    // expand the sequence column
-    if (_tablet_schema->has_sequence_col() && need_seq_col) {
-        bool has_replace_col = false;
+    has_replace_col = false;

Review Comment:
   the value seems always `false` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org