[GitHub] [daffodil] stevedlawrence commented on a change in pull request #728: Update genjavadoc-plugin to 0.18_2.13.8

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #728:
URL: https://github.com/apache/daffodil/pull/728#discussion_r784033040



##########
File path: daffodil-japi/build.sbt
##########
@@ -18,7 +18,7 @@
 enablePlugins(GenJavadocPlugin)
 enablePlugins(PublishJavadocPlugin)
 
-unidocGenjavadocVersion := "0.18_2.12.15"
+unidocGenjavadocVersion := "0.18_2.13.8"

Review comment:
       I think we don't actually want to merge this? The CI tests pass, but I assume we want to stick with the version of genjavadoc that matches our scala version (2.12.15)?
   
   In fact, looking at the GenJavaDocPlugin, I wonder if we should even being including the scala version in the value of `unidocGenjavadocVersion`? Looking at this file:
   
   https://github.com/sbt/sbt-unidoc/blob/master/src/main/scala/sbtunidoc/GenJavadocPlugin.scala
   
   The setting defaults to just "0.18" and uses `crossVersion` to get the right Scala version. Seems like maybe we should change this  back to just "0.18"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org