[kudu-CR] KUDU-2677 Implement new gflag for backup history retention

["Adar Dembo (Code Review)" <ge...@cloudera.org>]

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12327 )

Change subject: KUDU-2677 Implement new gflag for backup history retention
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12327/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12327/2//COMMIT_MSG@16
PS2, Line 16:  users can just raise the
            : new flag, and ideally we will keep the semantics of "I want to be able
            : to back up to this point" in future releases, minimizing user-end
            : configuration changes.
I feel like I never really understood this argument, but maybe that's because I'm missing some important detail. Could you flesh out this example some more, perhaps leveraging the future "anchor point" or "snapshot" functionality that's been discussed? Why wouldn't we have the same issue with --backup_max_age_sec as we do with --tablet_history_max_age_sec when we add those capabilities?


http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/tablet/tablet.cc@150
PS2, Line 150: TAG_FLAG(backup_max_age_sec, experimental);
Probably shouldn't be experimental if anyone who wants to do an incremental backup needs to tweak this.



-- 
To view, visit http://gerrit.cloudera.org:8080/12327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6c2c001c50f65e9acdfc032e8aa5efdacbd4d9e
Gerrit-Change-Number: 12327
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 02 Feb 2019 20:16:35 +0000
Gerrit-HasComments: Yes