You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/17 05:07:54 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1783: Specify scope of DataSource dependencies to test in module RDB
TeslaCN opened a new pull request #1783:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1783
Changes proposed in this pull request:
- Specify scope of DataSource dependencies to test in module RDB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1783: Specify scope of DataSource dependencies to test in module RDB
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1783:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1783#issuecomment-747210775
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=h1) Report
> Merging [#1783](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=desc) (f2d8b60) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/fa487f159a16101350a4401c48c0f9e309940a69?el=desc) (fa487f1) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1783 +/- ##
============================================
+ Coverage 85.86% 85.88% +0.01%
- Complexity 112 113 +1
============================================
Files 274 274
Lines 5923 5923
Branches 907 907
============================================
+ Hits 5086 5087 +1
+ Misses 508 507 -1
Partials 329 329
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `73.22% <0.00%> (+0.78%)` | `33.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=footer). Last update [fa487f1...f2d8b60](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1783: Specify scope of DataSource dependencies to test in module RDB
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1783:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1783#issuecomment-747210775
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=h1) Report
> Merging [#1783](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=desc) (f2d8b60) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/fa487f159a16101350a4401c48c0f9e309940a69?el=desc) (fa487f1) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1783 +/- ##
============================================
- Coverage 85.86% 85.76% -0.11%
Complexity 112 112
============================================
Files 274 274
Lines 5923 5923
Branches 907 907
============================================
- Hits 5086 5080 -6
- Misses 508 513 +5
- Partials 329 330 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=footer). Last update [fa487f1...f2d8b60](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1783?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1783: Specify scope of DataSource dependencies to test in module RDB
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1783:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org