You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2016/11/23 20:38:48 UTC
[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1233
TS-5062: Fix traffic_ctl to track plugin supplied configuration variables.
\u2026bles.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver yts-5062
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1233
----
commit ec47124a4ecd709cab5e198d6c8b4dc29903db0b
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date: 2016-11-23T16:36:30Z
TS-5062: Fix traffic_ctl to track plugin supplied configuration variables.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1223/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1116/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1104/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1214/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1218/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1233#discussion_r89939168
--- Diff: doc/developer-guide/api/functions/TSMgmtSourceGet.en.rst ---
@@ -0,0 +1,69 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed
+ with this work for additional information regarding copyright
+ ownership. The ASF licenses this file to you under the Apache
+ License, Version 2.0 (the "License"); you may not use this file
+ except in compliance with the License. You may obtain a copy of
+ the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied. See the License for the specific language governing
+ permissions and limitations under the License.
+
+.. include:: ../../../common.defs
+
+.. default-domain:: c
+
+TSMgmtSourceGet
+***************
+
+Synopsis
+========
+
+`#include <ts/ts.h>`
+
+.. function:: TSReturnCode TSMgmtSourceGet(const char * var_name, TSMgmtSource * result)
+
+Description
+===========
+
+Get the source of a value for a configuration variable. :arg:`var_name` is the name of the variable
+as a nul terminated string. The source value is stored in :arg:`result`. The function can return
+failure if :arg:`var_name` is not found.
+
+Types
+=====
+
+.. type:: TSMgmtSource
+
+ Source of the current value for a management (configuration) value.
+
+ .. macro:: TS_MGMT_SOURCE_NULL
+
+ Invalid value, no source available. This is primarily used as an initialization or error value
+ and should be returned only when an API call fails.
+
+ .. macro:: TS_MGMT_SOURCE_DEFAULT
+
+ The default value provided by the |TS| core.
+
+ .. macro:: TS_MGMT_SOURCE_PLUGIN
+
+ The default value provided by a plugin. This means the configuration variable itself was
+ created by a plugin and is not part of the |TS| core and the value has not been changed from
+ that default.
+
+ .. macro:: TS_MGMT_SOURCE_EXPLICIT
+
+ The value has been set in :file:`records.config` or via an explict API call (such as
+ :c:func:`TSMgmtIntSet`). Note this does not guarantee the value is not the default value, as
+ the variable could have been set to that value. This only means an administrator or plugin
+ explicit set the value.
+
+ .. macro:: TS_MGMT_SOURCE_ENV
+
+ The value was retrived from the process environment, overriding the default value.
--- End diff --
Needs a `Return` section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1220/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1113/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1111/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1211/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1108/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1233#discussion_r89939136
--- Diff: doc/developer-guide/api/functions/TSMgmtSourceGet.en.rst ---
@@ -0,0 +1,69 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed
+ with this work for additional information regarding copyright
+ ownership. The ASF licenses this file to you under the Apache
+ License, Version 2.0 (the "License"); you may not use this file
+ except in compliance with the License. You may obtain a copy of
+ the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied. See the License for the specific language governing
+ permissions and limitations under the License.
+
+.. include:: ../../../common.defs
+
+.. default-domain:: c
+
+TSMgmtSourceGet
+***************
+
+Synopsis
+========
+
+`#include <ts/ts.h>`
+
+.. function:: TSReturnCode TSMgmtSourceGet(const char * var_name, TSMgmtSource * result)
+
+Description
+===========
+
+Get the source of a value for a configuration variable. :arg:`var_name` is the name of the variable
+as a nul terminated string. The source value is stored in :arg:`result`. The function can return
+failure if :arg:`var_name` is not found.
+
+Types
+=====
+
+.. type:: TSMgmtSource
+
+ Source of the current value for a management (configuration) value.
+
+ .. macro:: TS_MGMT_SOURCE_NULL
--- End diff --
Why don't you just return this instead of `TS_ERROR`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1233: TS-5062: Fix traffic_ctl to track plugin s...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1233#discussion_r89399145
--- Diff: lib/ts/apidefs.h.in ---
@@ -798,6 +798,16 @@ typedef int64_t TSMgmtCounter;
typedef float TSMgmtFloat;
typedef char *TSMgmtString;
+/// The source of of management value.
+enum TSMgmtSource {
+ TS_MGMT_SOURCE_NULL, ///< No source / value not found.
+ TS_MGMT_SOURCE_DEFAULT, ///< Built in core default.
+ TS_MGMT_SOURCE_PLUGIN, ///< Plugin supplied default.
+ TS_MGMT_SOURCE_EXPLICIT, ///< Set by administrator (config file, external API, cluster, etc.)
+ TS_MGMT_SOURCE_ENV ///< Process environment variable.
+};
--- End diff --
This should be a typedef for consistency with all the other TSAPI enumerations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1112/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1215/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1219/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1233: TS-5062: Fix traffic_ctl to track plugin supplied...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1233
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1107/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---