[GitHub] mikewalch commented on a change in pull request #361: ACCUMULO-4784 - Create builder for Connector

[GitBox <gi...@apache.org>]

mikewalch commented on a change in pull request #361: ACCUMULO-4784 - Create builder for Connector
URL: https://github.com/apache/accumulo/pull/361#discussion_r165197001
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/ConnectionInfo.java
 ##########
 @@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.accumulo.core.client;
+
+public interface ConnectionInfo {
+
+}
 
 Review comment:
   `ConnectionInfo` lacks methods as I am not sure what to expose to users.  I don't want to expose most of the methods in `ConnectionInfoImpl`. However, I would say `ConnectionInfo` is not complete as it should have some methods for users to get basic information on their connection and all client properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services