You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/21 01:31:33 UTC
[GitHub] [druid] JaeGeunBang opened a new pull request #9550: Change
backtick(``) and fix broken links.
JaeGeunBang opened a new pull request #9550: Change backtick(``) and fix broken links.
URL: https://github.com/apache/druid/pull/9550
### Description
Sorry. The pull request below has a problem and sends a new pull request. (https://github.com/apache/druid/pull/9538)
@clintropolis
As suggested, Change backtick(``) links and fix broken links.
This PR has:
- [x] been self-reviewed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] JaeGeunBang commented on a change in pull request #9550:
Change backtick(``) and fix broken links.
Posted by GitBox <gi...@apache.org>.
JaeGeunBang commented on a change in pull request #9550: Change backtick(``) and fix broken links.
URL: https://github.com/apache/druid/pull/9550#discussion_r396334620
##########
File path: dev/intellij-setup.md
##########
@@ -46,7 +46,7 @@ This also assumes you have [ZooKeeper](http://zookeeper.apache.org/releases.html
Before running the apps, you should do a `mvn clean install -DskipTests` in the Druid source in order to make sure directories are populated correctly.
## XML App Def
-You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in [.idea/runConfigurations](.idea/runConfigurations) in the Druid source code.
+You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in [`.idea/runConfigurations`](../.idea/runConfigurations) in the Druid source code.
Review comment:
@clintropolis
Thank you!
Commit again based on your comments.
- change backtick (``).
- fix broken links.
- no link `.idea/runConfigurations`
- delete runConfiguration/ in /.idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9550:
Change backtick(``) and fix broken links.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9550: Change backtick(``) and fix broken links.
URL: https://github.com/apache/druid/pull/9550#discussion_r395950938
##########
File path: dev/intellij-setup.md
##########
@@ -24,7 +24,7 @@ setups of Druid.
## Project SDK
The "SDK", configured for the Druid project, *must* be called `1.8`, to avoid annoying changes of
-[.idea/misc.xml](`.idea/misc.xml`) file, that you shouldn't check into your commits. If you don't have an SDK on your
+[`.idea/misc.xml`](../.idea/misc.xml) file, that you shouldn't check into your commits. If you don't have an SDK on your
Review comment:
I _think_ the link can just be ```[`.idea/misc.xml`](/.idea/misc.xml)``` since if it starts with `/` it treats it as the repository root.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #9550: Change backtick(``)
and fix broken links.
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #9550: Change backtick(``) and fix broken links.
URL: https://github.com/apache/druid/pull/9550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9550:
Change backtick(``) and fix broken links.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9550: Change backtick(``) and fix broken links.
URL: https://github.com/apache/druid/pull/9550#discussion_r395951058
##########
File path: dev/intellij-setup.md
##########
@@ -46,7 +46,7 @@ This also assumes you have [ZooKeeper](http://zookeeper.apache.org/releases.html
Before running the apps, you should do a `mvn clean install -DskipTests` in the Druid source in order to make sure directories are populated correctly.
## XML App Def
-You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in [.idea/runConfigurations](.idea/runConfigurations) in the Druid source code.
+You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in [`.idea/runConfigurations`](../.idea/runConfigurations) in the Druid source code.
Review comment:
If we end up not adding the run configurations, I think this should not be a link, and just `.idea/runConfigurations`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9550:
Change backtick(``) and fix broken links.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9550: Change backtick(``) and fix broken links.
URL: https://github.com/apache/druid/pull/9550#discussion_r395950973
##########
File path: dev/teamcity.md
##########
@@ -84,7 +84,7 @@ active:
8. Press the `Apply` button, then `OK` to exit the inspection preferences.
-9. If you did everything right, file `.idea/inspectionProfiles/Druid.xml` should be updated with a new
+9. If you did everything right, file [`.idea/inspectionProfiles/Druid.xml`](../.idea/inspectionProfiles/Druid.xml) should be updated with a new
Review comment:
same comment: ```[`.idea/inspectionProfiles/Druid.xml`](/.idea/inspectionProfiles/Druid.xml)```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9550:
Change backtick(``) and fix broken links.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9550: Change backtick(``) and fix broken links.
URL: https://github.com/apache/druid/pull/9550#discussion_r395950418
##########
File path: .idea/runConfigurations/Coordinator.xml
##########
@@ -0,0 +1,17 @@
+<component name="ProjectRunConfigurationManager">
Review comment:
Ah, now that I think about it, we probably don't want to actually add these files to git, because developers will likely modify them as needed for their environment and whatever they are testing, so should not be tracked.
If we do add them, they should probably be suffixed with `example`, so like this would be `Coordinator-example.xml` or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org