You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bilgin Ibryam (JIRA)" <ji...@apache.org> on 2006/10/19 18:52:44 UTC
[jira] Created: (OFBIZ-391) Bug in room booking
Bug in room booking
-------------------
Key: OFBIZ-391
URL: http://issues.apache.org/jira/browse/OFBIZ-391
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: ecommerce
Reporter: Bilgin Ibryam
Hi,
If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
Here is a little patch that solves the problem.
Regards,
Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-391) Bug in room booking
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=comments#action_12449134 ]
Jacques Le Roux commented on OFBIZ-391:
---------------------------------------
OK,
I can't create an account to book a room on Open travel, I get :
The Following Errors Occurred:
* ERROR: Could not complete the Create Contact Mechanism [file:/opt/ofbiz/test/ofbiz/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml#createContactMech] process [problem creating the newValue value: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Failure in getNextSeqId operation for seqName [ContactMech]: java.lang.IllegalArgumentException: Could not get next sequenced ID for sequence name: ContactMech. Rolling back transactionjava.lang.IllegalArgumentException: Could not get next sequenced ID for sequence name: ContactMech (Could not get next sequenced ID for sequence name: ContactMech)] calling service createContactMech in createPostalAddress calling service createPostalAddress in createPartyPostalAddress
However I see that there are no rooms booked after the 29 oct 2006. One question a this stage, how are you using TechDataCalendarExcDay ?
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Attachments: OrderServices.patch, Screenshot-1.png
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-391) Bug in room booking
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=all ]
Bilgin Ibryam updated OFBIZ-391:
--------------------------------
Attachment: Screenshot-1.png
Hi,
Sorry for the late answer. I just updated ofbiz and tried to make a reservation, but the same problem - i cannot see the reservations after 29 october.
Btw there is no connection between month.ftl and the calendar in the fixed asset, so (OFBIZ-392) is not solving the problem.
I am not sure about English and French settings but in Bulgaria we change the time with minus 1 hour at 29 october (because of Daylight saving time). I think this is the reason for lost one hour in the reservation. In the screenshot of the TechDataCalendarExcDay you can see the lost hour and this is the problem for the visualization (month.bsh).
I got the same problem even I make a reservation at hotel demo from http://demo.opentravelsystem.org/hotelfrontend/control/product/~category_id=HotelDemoStore-Promo/~product_id=HDS-RoomPromo - the reservations after 29 are not visualized at :https://test.opentravelsystem.org/hotelbackend/control/ListFixedAssetCalendar?fixedAssetId=HDS-Room
Regards,
Bilgin
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Attachments: OrderServices.patch, Screenshot-1.png
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-391) Bug in room booking
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=comments#action_12449532 ]
Bilgin Ibryam commented on OFBIZ-391:
-------------------------------------
Hi,
1. I donot have any idea, why it is down.
2. I can make reservations from ecommerce without any problems.
3. To make a reservation, the products/rooms should have Price Type = Default Price, Purpose = Purchase/Initial AND Currency = American Dollar [USD].
4. You are right, we cannot make reservation from backend.
About TechDataCalendarExcDay : I can see there the reservations. For every day of the reservation is created one line on this table. And the important things is the column exceptionDateStartTime to be in this format :yyyyy-mm-dd 00:00:00.0
Next week i can work on https://issues.apache.org/jira/browse/OFBIZ-2 . What can i do about it ?
Regards,
Bilgin
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OrderServices.patch, Screenshot-1.png
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-391) Bug in room booking
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=all ]
Bilgin Ibryam updated OFBIZ-391:
--------------------------------
Attachment: OrderServices.patch
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Attachments: OrderServices.patch
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-391) Bug in room booking
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=comments#action_12449061 ]
Bilgin Ibryam commented on OFBIZ-391:
-------------------------------------
Hi all,
can someone review and commit my patch ? It is only one line !
I tried booking in http://demo.dejc.com:8080/ecommerce/control/main and still the same bug. You can check there the database and the calendar if needed.
Thanks,
Bilgin
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Attachments: OrderServices.patch, Screenshot-1.png
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-391) Bug in room booking
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=comments#action_12449609 ]
Jacques Le Roux commented on OFBIZ-391:
---------------------------------------
Thanks for tips,
You said "But the part for setting the time zone is not completed and I need help for the best practice to implement it."
What kind of advices do you need please ? Sorry I have not a lot of time to put in this...
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OrderServices.patch, Screenshot-1.png
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-391) Bug in room booking
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=comments#action_12449104 ]
Jacques Le Roux commented on OFBIZ-391:
---------------------------------------
Hi Bilgin,
Only one line but difficult to test :
1. http://demo.opentravelsystem.org/hotelfrontend/control/product/~category_id=HotelDemoStore-Promo/~product_id=HDS-RoomPromo and
https://test.opentravelsystem.org/hotelbackend/control/ListFixedAssetCalendar?fixedAssetId=HDS-Room are down at (12/11/2006 8:28)
2. On Dejc I got this error willing to complete orders. ERROR: Could not complete the Sub-method used by quickShip methods to create a shipment [file:/home/ofbdemo/ofbiz/applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml#createShipmentForFacilityAndShipGroup] process [problem invoking the [updateShipment] service with the map named [packedContext] containing [[shipmentId=10004, statusId=SHIPMENT_SHIPPED, userLogin=[GenericEntity:UserLogin][createdStamp,2006-11-11 04:06:24.262(java.sql.Timestamp)][createdTxStamp,2006-11-11 04:06:24.024(java.sql.Timestamp)][currentPassword,47ca69ebb4bdc9ae0adec130880165d2cc05db1a(java.lang.String)][disabledDateTime,null()][enabled,Y(java.lang.String)][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastUpdatedStamp,2006-11-12 00:20:37.071(java.sql.Timestamp)][lastUpdatedTxStamp,2006-11-12 00:20:37.071(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][successiveFailedLogins,null()][userLoginId,admin(java.lang.String)], locale=fr]]: Problems with the transaction. (Service target threw an unexpected exception (/ by zero))]
Orders WS10001 and WS10002 today
3. On my machines I cant' make a reservation trough eCommerce because rooms have no prices (even if it's ok in backend catalog). Can't understand why (std ant-run-install)
4. You can't make a sale reservation through the backend (you get : "The starting date of the reservation is missing....")
BTW have you got some time to enhance https://issues.apache.org/jira/browse/OFBIZ-2 ?
ASA demo.opentravelsystem is ok I will re-review this issue...
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Attachments: OrderServices.patch, Screenshot-1.png
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-391) Bug in room booking
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-391?page=all ]
Jacques Le Roux closed OFBIZ-391.
---------------------------------
Fix Version/s: SVN trunk
Resolution: Fixed
Assignee: Jacques Le Roux
OK, I finally commited your patch even if I can't test it because it seems good and harmless, sorry for the delay. Committed in revision 473963.
> Bug in room booking
> -------------------
>
> Key: OFBIZ-391
> URL: http://issues.apache.org/jira/browse/OFBIZ-391
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: ecommerce
> Reporter: Bilgin Ibryam
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OrderServices.patch, Screenshot-1.png
>
>
> Hi,
> If we make a room booking in ecommerce application, including the last Sunday of October ( 29 October ), the bookings that are after that date are not visualized in the fixed asset calendar. Because of Daylight Saving Time, we lost one hour and even the reservation is marked in the Database ( with -1 hour ) we cannot see the reservations on the fixed asset calendar.
> Here is a little patch that solves the problem.
> Regards,
> Bilgin
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira