You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2012/05/16 07:46:12 UTC
[jira] [Created] (HIVE-3030) escape more chars for script operator
Namit Jain created HIVE-3030:
--------------------------------
Summary: escape more chars for script operator
Key: HIVE-3030
URL: https://issues.apache.org/jira/browse/HIVE-3030
Project: Hive
Issue Type: Bug
Reporter: Namit Jain
Assignee: Namit Jain
Only new line was being escaped.
The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277054#comment-13277054 ]
Namit Jain commented on HIVE-3030:
----------------------------------
@Carl, I will address the comments.
I am not sure, why arc stopped working since yesterday. Let me play around with it.
I agree, having comments on jira is necessary
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279401#comment-13279401 ]
Namit Jain commented on HIVE-3030:
----------------------------------
https://reviews.facebook.net/D3261
Siying, can you take a look ?
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3030) escape more chars for script operator
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3030:
---------------------------------
Component/s: Query Processor
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280294#comment-13280294 ]
Siying Dong commented on HIVE-3030:
-----------------------------------
Logic looks good to me. I'll run unit tests now. In the mean time, can you add tests to cover those new cases? Cases like escaping '\', and unescaping cases like '\\', ,'\\\t' or '\\\t'?
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276505#comment-13276505 ]
Namit Jain commented on HIVE-3030:
----------------------------------
https://reviews.facebook.net/D3261
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281137#comment-13281137 ]
Siying Dong commented on HIVE-3030:
-----------------------------------
Committed. Thanks Namit!
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280351#comment-13280351 ]
Namit Jain commented on HIVE-3030:
----------------------------------
https://reviews.facebook.net/D3261 updated - tests added.
@Carl, It seems little clumsy for the user to specify the list of escape characters.
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-3030) escape more chars for script operator
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong resolved HIVE-3030.
-------------------------------
Resolution: Fixed
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280470#comment-13280470 ]
Siying Dong commented on HIVE-3030:
-----------------------------------
Tests look good to me. Will run the test suites. Let's open a follow-up JIRA to escape a more complete list of characters.
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282149#comment-13282149 ]
Hudson commented on HIVE-3030:
------------------------------
Integrated in Hive-trunk-h0.21 #1445 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1445/])
HIVE-3030 escape more chars for script operator (Namit Jain via Siying Dong) (Revision 1341589)
Result = SUCCESS
sdong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1341589
Files :
* /hive/trunk/bin/hive
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/conf/hive-default.xml.template
* /hive/trunk/data/scripts/doubleescapedtab.py
* /hive/trunk/data/scripts/escapedcarriagereturn.py
* /hive/trunk/data/scripts/escapednewline.py
* /hive/trunk/data/scripts/escapedtab.py
* /hive/trunk/data/scripts/newline.py
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TextRecordReader.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TextRecordWriter.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
* /hive/trunk/ql/src/test/queries/clientpositive/newline.q
* /hive/trunk/ql/src/test/results/clientpositive/newline.q.out
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.10.0
>
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3030) escape more chars for script operator
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3030:
---------------------------------
Status: Open (was: Patch Available)
I think we should wait for the tests to get added before committing this patch, especially since this modifies a public API (i.e. adding a new configuration property).
Also, instead of making this a binary property, would it make more sense to allow the user to specify the list of characters that the ScriptOperator should escape?
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3030) escape more chars for script operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3030:
-----------------------------
Status: Patch Available (was: Open)
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281141#comment-13281141 ]
Carl Steinbach commented on HIVE-3030:
--------------------------------------
@Namit/Siying: What's the followup JIRA ticket ID?
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.10.0
>
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280399#comment-13280399 ]
Siying Dong commented on HIVE-3030:
-----------------------------------
Discussed with Namit offline. He is going to add one more test case now.
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3030) escape more chars for script operator
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3030:
---------------------------------
Status: Open (was: Patch Available)
@Namit: I added some comments on phabricator. Is it possible to have phabricator copy the comments to JIRA? Do we know why this stopped working? If this keeps happening I think we need to revert back to RB since having a permanent record on JIRA is a requirement.
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278018#comment-13278018 ]
Siying Dong commented on HIVE-3030:
-----------------------------------
Here is a general problem (maybe not related to new change to this patch): there is no way to output "\n" back to Hive. It will be translated to a <new_line>. In a similar way, if the column contains "\n", it will not be escaped so the transform script will have no way to distinguish this from a new line. With this patch, more cases like this will be added. Maybe not for this patch but as a follow-up, we might want to escape \\ too to keep the escaping mapping a complete one.
Other than that, the patch looks good to me.
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3030) escape more chars for script operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3030:
-----------------------------
Status: Patch Available (was: Open)
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278020#comment-13278020 ]
Siying Dong commented on HIVE-3030:
-----------------------------------
I meaned "Maybe not for this patch but as a follow-up, we might want to escape <slash><slash> too to keep the escaping mapping a complete one."
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277160#comment-13277160 ]
Namit Jain commented on HIVE-3030:
----------------------------------
I addressed the comments.
I could not make arc work with jira.
Copying the old comments from Carl for reference:
conf/hive-default.xml.template
1276 ↗
(On Diff #10293)
I think this should be called 'hive.transform.escape.input' since the fact that this affects the behavior of the ScriptOperator is an implementation detail that is hidden from users.
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
118 ↗
(On Diff #10293)
Please remove these braces.
ql/src/test/queries/clientpositive/newline.q
2 ↗
(On Diff #10293)
Please add a test that transforms data containing TABs and carriage returns.
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3030) escape more chars for script operator
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3030:
---------------------------------
Fix Version/s: 0.10.0
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.10.0
>
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280460#comment-13280460 ]
Namit Jain commented on HIVE-3030:
----------------------------------
Added more tests https://reviews.facebook.net/D3261
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3030) escape more chars for script
operator
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277804#comment-13277804 ]
Namit Jain commented on HIVE-3030:
----------------------------------
Kevin, can you commit it if you tests have finished.
> escape more chars for script operator
> -------------------------------------
>
> Key: HIVE-3030
> URL: https://issues.apache.org/jira/browse/HIVE-3030
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> Only new line was being escaped.
> The same behavior needs to be done for carriage returns, and tabs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira