You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by lvfangmin <gi...@git.apache.org> on 2018/08/09 04:54:38 UTC
[GitHub] zookeeper pull request #594: [ZOOKEEPER-3116] Make the DataTree.approximateD...
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/594
[ZOOKEEPER-3116] Make the DataTree.approximateDataSize more efficient
Cache the approximate data tree size, and update it when txns applied to data tree, this could make this query not that expensive.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-3116
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/594.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #594
----
commit 21243f5effc23e68c57f9be93558ddb006e5f504
Author: Fangmin Lyu <al...@...>
Date: 2018-08-09T04:51:55Z
cache the approximate data size in DataTree
----
---
[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/594
@lvfangmin You got a findbugs warning:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2063/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
Other than that it's ready to go.
---
[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/594
Thanks @anmolnar, I've updated the code to read the node.data inside the synchronized section. I'll check the Findbugs result for the updated patch.
---
[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/594
Committed to master.
Thanks @lvfangmin !
---
[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/594
@lvfangmin I this is a very good improvement. Do you think that existing unit tests cover this functionality or it might be beneficial to add some?
---
[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/594
@anmolnar the updated code has passed all the tests and no Findbugs warning.
---
[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/594
@anmolnar I think this should be ready to go in now.
---
[GitHub] zookeeper pull request #594: [ZOOKEEPER-3116] Make the DataTree.approximateD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/594
---