You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/18 14:11:40 UTC

[GitHub] [incubator-nuttx] YuuichiNakamura commented on a change in pull request #1271: Feature/syscall instrumentation

YuuichiNakamura commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442256681



##########
File path: arch/arm/src/Makefile
##########
@@ -69,6 +69,19 @@ else
   NUTTX = "$(TOPDIR)$(DELIM)nuttx$(EXEEXT)"
 endif
 
+# Additional rules for system call wrapper
+
+ifeq ($(CONFIG_BUILD_FLAT),y)
+ifeq ($(CONFIG_SCHED_INSTRUMENTATION_SYSCALL),y)

Review comment:
       This part is used to create the additional linker command option "--wrap=\<function\>" for gnu linker.
   This is needed to supersede the direct kernel function call from application into newly added system call wrapper library.
   (see: https://github.com/YuuichiNakamura/nuttx-task-tracer-doc/blob/master/NuttXTaskTracerInternals.md#flat-build)
   
   Only FLAT build requires this treatment because PROTECTED/KERNEL build already have system call stub which can insert sched_note_syscall_enter/leave.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org