You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "WuChuSheng1 (via GitHub)" <gi...@apache.org> on 2023/02/06 14:50:24 UTC
[GitHub] [skywalking-banyandb] WuChuSheng1 opened a new pull request, #248: This PR is to merge create the stream function
WuChuSheng1 opened a new pull request, #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248
**This PR is to merge create the stream function.**
- **In this function, you can right-click the menu and click "new resources" button.**
- **Then, It will enter the create stream page.**
- **On this page, you can set the name of the stream.**
- **Of course, This page provides the function of editing Tag Families. You can click the "Add" button to edit.**
- **You can add multiple Tag Families and Tags. It is worth noting that Tags are unique.**
- **Of course, you can also edit and delete the existing Tag Family.**
- **When you click the "submit" button, a new stream will be created, and the creation page will be closed and automatically enter the new stream.**
- **When you do not need the stream, you can right-click the menu and click the "delete" button to delete it.**
**It is worth noting that at present, only new streams are supported, and stream editing is temporarily not supported.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #248: Adding support for creating streams
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #248: This PR is to merge create the stream function
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248#issuecomment-1419214976
# [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#248](https://codecov.io/gh/apache/skywalking-banyandb/pull/248?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b06baa) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/ad6a81c726640c8ffb8805adac4f43ffa5b2c423?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad6a81c) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 45.88% 45.88%
=======================================
Files 87 87
Lines 8896 8896
=======================================
Hits 4082 4082
Misses 4430 4430
Partials 384 384
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] WuChuSheng1 commented on pull request #248: Adding support for creating streams
Posted by "WuChuSheng1 (via GitHub)" <gi...@apache.org>.
WuChuSheng1 commented on PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248#issuecomment-1420960920
> 1. At the top of creating the page, "Catalog" should be in place of "Type". "Operation" could replace "Operator"
> 2. Remove the prefix, "TAG_TYPE_", from the tag type's literal. For example, "INT" could substitute for "TAG_TYPE_INT".
> 3. Deletion procedure should get confirmation from the user before deleting a stream. A confirm dialog should pop up when the user clicks the delete button.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] WuChuSheng1 commented on pull request #248: This PR is to merge create the stream function
Posted by "WuChuSheng1 (via GitHub)" <gi...@apache.org>.
WuChuSheng1 commented on PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248#issuecomment-1420104368
> Please don't form your PR title like this, it gets carried over to the squash and merge phase (will be used as the Top commit message) Maybe try something more straightforward like `Adding support for creating streams` (just an example)
ok, Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] Superskyyy commented on pull request #248: This PR is to merge create the stream function
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248#issuecomment-1419294460
Please don't form your PR title like this, it gets carried over to the squash and merge phase (will be used as the Top commit message) Maybe try something more straightforward like `Adding support for creating streams` (just an example)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] WuChuSheng1 commented on pull request #248: Adding support for creating streams
Posted by "WuChuSheng1 (via GitHub)" <gi...@apache.org>.
WuChuSheng1 commented on PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248#issuecomment-1426613054
> I think this looks good to me. But we have to wait till v0.3.0 is released, which is in the voting process.
Thank you very much for your approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #248: Adding support for creating streams
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248#issuecomment-1422638247
I think this looks good to me. But we have to wait till v0.3.0 is released, which is in the voting process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #248: Adding support for creating streams
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #248:
URL: https://github.com/apache/skywalking-banyandb/pull/248#issuecomment-1420782263
Some tips around git practice: Your branch contains commits merged last year. You could get a clean commit list by rebasing on the recent main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org