You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "garydgregory (via GitHub)" <gi...@apache.org> on 2023/04/18 18:27:17 UTC

[GitHub] [commons-io] garydgregory commented on pull request #377: [IO-769] FileUtils copyDirectory() should NOT use COPY_ATTRIBUTES

garydgregory commented on PR #377:
URL: https://github.com/apache/commons-io/pull/377#issuecomment-1513619421

   > Why did the previous setLastModified(File, File) need PathUtils.setLastModifiedTime() if
   > sourceFile.isFile() was true, but needed setLastModifiedTime(File, long) if sourceFile.isFile() was false. [This is the code I'm inquiring about](https://github.com/apache/commons-io/blob/f22a4227401855ecbfdf8184bbe37275c3aeb5c3/src/main/java/org/apache/commons/io/FileUtils.java#L2854-L2857) which will be lost with this PR, so I'd like to understand the history of this to ensure we aren't introducing a regression with the new change.
   > 
   
   This might have to do with different APIs [not] being able to set directory timestamps.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org