You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2026/04/20 04:50:47 UTC
[PR] Add test file cleanup and fix .gitignore for Python tests [tsfile]
JackieTien97 opened a new pull request, #787:
URL: https://github.com/apache/tsfile/pull/787
## Summary
- Wrap `test_lower_case_name` and `test_tsfile_config` in `try/finally` blocks to ensure generated `.tsfile` files are cleaned up after tests
- Fix `test_tree_all_datatype_query_to_dataframe_variants` cleanup bug: was deleting `tablet_write_and_read.tsfile` instead of `record_write_and_read.tsfile`
- Add `python/tsfile/dataset/__pycache__` to `.gitignore`
## Test plan
- [x] Verify tests still pass after adding `try/finally` cleanup
- [x] Verify no leftover `.tsfile` files remain after running tests
- [x] Code formatted with Black (no changes needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test file cleanup and fix .gitignore for Python tests [tsfile]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #787:
URL: https://github.com/apache/tsfile/pull/787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test file cleanup and fix .gitignore for Python tests [tsfile]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #787:
URL: https://github.com/apache/tsfile/pull/787#issuecomment-4277973441
## [Codecov](https://app.codecov.io/gh/apache/tsfile/pull/787?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 62.75%. Comparing base ([`2ab087b`](https://app.codecov.io/gh/apache/tsfile/commit/2ab087b64a62784f03f77ed2a08d09b74266b958?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`654b1ec`](https://app.codecov.io/gh/apache/tsfile/commit/654b1ec955bc2edc746b03033e68dd9f8b337504?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #787 +/- ##
========================================
Coverage 62.75% 62.75%
========================================
Files 706 706
Lines 42836 42836
Branches 6324 6324
========================================
+ Hits 26881 26882 +1
Misses 14963 14963
+ Partials 992 991 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tsfile/pull/787?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org