[GitHub] [incubator-eventmesh] MajorHe1 commented on a diff in pull request #2484: [ISSUE #2483] use log instead of print when exception occurred in CloudEventTCPSubClient.java

[GitBox <gi...@apache.org>]

MajorHe1 commented on code in PR #2484:
URL: https://github.com/apache/incubator-eventmesh/pull/2484#discussion_r1041690104


##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java:
##########
@@ -135,7 +135,7 @@ public void close() {
             goodbye();
             super.close();
         } catch (Exception ex) {
-            ex.printStackTrace();
+            log.warn("exception occurred when close", ex);

Review Comment:
   already changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org