You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "dtrunk90 (via GitHub)" <gi...@apache.org> on 2023/06/19 07:07:29 UTC

[GitHub] [ofbiz-framework] dtrunk90 opened a new pull request, #646: Fixed: Several IllegalArgumentExceptions

dtrunk90 opened a new pull request, #646:
URL: https://github.com/apache/ofbiz-framework/pull/646

   Don't use all service parameters in where condition since entities don't have all fields which results in:
   
   java.lang.IllegalArgumentException: FieldName product not found for entity: ProductStore
   	at org.apache.ofbiz.entity.condition.EntityExpr.checkRhsType(EntityExpr.java:199)
   	at org.apache.ofbiz.entity.condition.EntityExpr.makeWhereString(EntityExpr.java:118)
   	at org.apache.ofbiz.entity.condition.EntityJoinOperator.addSqlValue(EntityJoinOperator.java:74)
   	at org.apache.ofbiz.entity.condition.EntityConditionListBase.makeWhereString(EntityConditionListBase.java:77)
   	at org.apache.ofbiz.entity.condition.EntityJoinOperator.addSqlValue(EntityJoinOperator.java:74)
   	at org.apache.ofbiz.entity.condition.EntityConditionListBase.makeWhereString(EntityConditionListBase.java:77)
   	at org.apache.ofbiz.entity.datasource.GenericDAO.makeConditionWhereString(GenericDAO.java:828)
   	at org.apache.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:732)
   	at org.apache.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:140)
   	at org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1579)
   	at org.apache.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1613)
   	at org.apache.ofbiz.entity.util.EntityQuery.query(EntityQuery.java:455)
   	at org.apache.ofbiz.entity.util.EntityQuery.queryList(EntityQuery.java:380)
   	at org.apache.ofbiz.entity.util.EntityQuery.queryOne(EntityQuery.java:421)
   	at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)
   	at ProductStoreServices.isStoreInventoryAvailableOrNotRequired(ProductStoreServices.groovy:357)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] nmalin commented on pull request #646: Fixed: Several IllegalArgumentExceptions

Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on PR #646:
URL: https://github.com/apache/ofbiz-framework/pull/646#issuecomment-1596827632

   No worries @dtrunk90 happy that you solved you pb. If you found a potential one, don't hesitate to submit it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] dtrunk90 commented on pull request #646: Fixed: Several IllegalArgumentExceptions

Posted by "dtrunk90 (via GitHub)" <gi...@apache.org>.
dtrunk90 commented on PR #646:
URL: https://github.com/apache/ofbiz-framework/pull/646#issuecomment-1596743493

   FYI: I'm running an older ofbiz version here, not trunk. I just noticed this happened here after cherry picking the whole history of `ProductStoreServices.groovy`. Sorry, should have mentioned that before. I don't know if this issue still persists on trunk, but it was here. Maybe I'm just missing a commit which resolves the PK only from the service context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] dtrunk90 closed pull request #646: Fixed: Several IllegalArgumentExceptions

Posted by "dtrunk90 (via GitHub)" <gi...@apache.org>.
dtrunk90 closed pull request #646: Fixed: Several IllegalArgumentExceptions
URL: https://github.com/apache/ofbiz-framework/pull/646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #646: Fixed: Several IllegalArgumentExceptions

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #646:
URL: https://github.com/apache/ofbiz-framework/pull/646#issuecomment-1596630674

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=646)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=646&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=646) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=646&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] nmalin commented on pull request #646: Fixed: Several IllegalArgumentExceptions

Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on PR #646:
URL: https://github.com/apache/ofbiz-framework/pull/646#issuecomment-1596688786

   Hello danny thanks for your issue, just before I wish control why the EntityQuery doesn't resolve correctly the pk on context


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] dtrunk90 commented on pull request #646: Fixed: Several IllegalArgumentExceptions

Posted by "dtrunk90 (via GitHub)" <gi...@apache.org>.
dtrunk90 commented on PR #646:
URL: https://github.com/apache/ofbiz-framework/pull/646#issuecomment-1596752143

   Yeah, sorry. This was an issue on my side only. After picking 3080813151974e237b80e45ebcb6a1db5b775d43 and 7d3ad82758820c5a83dbe821d52bb46918aaa134 it works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org