[GitHub] [calcite] xndai commented on a change in pull request #1853: [CALCITE-3851] Replace the node importance map with a set for pruned nodes

[GitBox <gi...@apache.org>]

xndai commented on a change in pull request #1853: [CALCITE-3851] Replace the node importance map with a set for pruned nodes
URL: https://github.com/apache/calcite/pull/1853#discussion_r392516215
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
 ##########
 @@ -221,9 +221,13 @@ public long getRelMetadataTimestamp(RelNode rel) {
     return 0;
   }
 
+  @Deprecated
   public void setImportance(RelNode rel, double importance) {
   }
 
+  public void pruneNode(RelNode rel) {
+  }
 
 Review comment:
   I suggest just name it "prune", since it's pretty clear that you are going to prune a RelNode by looking at the parameter. It's also consistent with the original naming (setImportance() not setNodeImportance()).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services