You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by el...@apache.org on 2020/06/27 09:11:32 UTC
svn commit: r1879253 - /httpd/httpd/trunk/server/util_script.c
Author: elukey
Date: Sat Jun 27 09:11:32 2020
New Revision: 1879253
URL: http://svn.apache.org/viewvc?rev=1879253&view=rev
Log:
server/util_script.c: tune logging Last-Modified header
Follow up after Joe's feedback in STATUS:
- If APR_DATE_BAD is returned for Last-Modified, log it at INFO level
(as opposed to trace).
- Remove unnecessary guard for APLOGrtrace1(r).
Modified:
httpd/httpd/trunk/server/util_script.c
Modified: httpd/httpd/trunk/server/util_script.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_script.c?rev=1879253&r1=1879252&r2=1879253&view=diff
==============================================================================
--- httpd/httpd/trunk/server/util_script.c (original)
+++ httpd/httpd/trunk/server/util_script.c Sat Jun 27 09:11:32 2020
@@ -718,9 +718,8 @@ AP_DECLARE(int) ap_scan_script_header_er
}
}
else {
- if (APLOGrtrace1(r))
- ap_log_rerror(SCRIPT_LOG_MARK, APLOG_TRACE1, 0, r,
- "Ignored invalid header value: Last-Modified: '%s'", l);
+ ap_log_rerror(SCRIPT_LOG_MARK, APLOG_INFO, 0, r,
+ "Ignored invalid header value: Last-Modified: '%s'", l);
}
}
else if (!ap_cstr_casecmp(w, "Set-Cookie")) {
Re: svn commit: r1879253 - /httpd/httpd/trunk/server/util_script.c
Posted by Luca Toscano <to...@gmail.com>.
On Mon, Jun 29, 2020 at 9:12 AM Ruediger Pluem <rp...@apache.org> wrote:
>
>
>
> On 6/27/20 11:11 AM, elukey@apache.org wrote:
> > Author: elukey
> > Date: Sat Jun 27 09:11:32 2020
> > New Revision: 1879253
> >
> > URL: http://svn.apache.org/viewvc?rev=1879253&view=rev
> > Log:
> > server/util_script.c: tune logging Last-Modified header
> >
> > Follow up after Joe's feedback in STATUS:
> > - If APR_DATE_BAD is returned for Last-Modified, log it at INFO level
> > (as opposed to trace).
> > - Remove unnecessary guard for APLOGrtrace1(r).
>
>
> As this is now a APLOG_INFO, can you please add an APLOGNO?
> For further details please have a look at docs/log-message-tags/README
Thanks for the pointer, hopefully fixed with r1879348.
Luca
Re: svn commit: r1879253 - /httpd/httpd/trunk/server/util_script.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 6/27/20 11:11 AM, elukey@apache.org wrote:
> Author: elukey
> Date: Sat Jun 27 09:11:32 2020
> New Revision: 1879253
>
> URL: http://svn.apache.org/viewvc?rev=1879253&view=rev
> Log:
> server/util_script.c: tune logging Last-Modified header
>
> Follow up after Joe's feedback in STATUS:
> - If APR_DATE_BAD is returned for Last-Modified, log it at INFO level
> (as opposed to trace).
> - Remove unnecessary guard for APLOGrtrace1(r).
As this is now a APLOG_INFO, can you please add an APLOGNO?
For further details please have a look at docs/log-message-tags/README
Regards
Rüdiger