You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2003/02/11 18:11:55 UTC
Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include
libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion
kfogel@tigris.org wrote:
>Author: kfogel
>Date: 2003-02-10 18:00:30 -0600 (Mon, 10 Feb 2003)
>New Revision: 4824
>
>Added:
> trunk/subversion/libsvn_subr/cmdline.c
>Removed:
> trunk/subversion/clients/init_cmdline.h
>Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/include/svn_pools.h
> trunk/subversion/svnadmin/main.c
> trunk/subversion/svnlook/main.c
> trunk/subversion/svnserve/main.c
> trunk/subversion/svnversion/main.c
> trunk/subversion/tests/libsvn_subr/target-test.c
>Log:
>Replace an unfamiliar mess with a familiar one:
>
>* subversion/clients/init_cmdline.h: Removed.
>
>* subversion/libsvn_subr/cmdline.c: New file.
>
>* subversion/include/svn_pools.h
> (svn_cmdline_init): New prototype, here for lack of a better place.
> See also comment about possible move to APR.
>
>
As you might have guessed, given the last paragraph above, I don't agree
with putting this into libsvn_subr. It doesn't belong there. We need a
separate library that contains only utilities for our command-line
clients. There are other things that should go there; for instance,
svn_path_internal_style and svn_path_local_style don't belong in
libsvn_subr, nor does opt.c. I also strongly suspect that the
command-line client support library should _only_ exist as a static lib,
not a shared one. I'd suggest refactoring all this into a new directory
under subversion/clients.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include
libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion
Posted by Branko Čibej <br...@xbc.nu>.
Karl Fogel wrote:
>Branko Čibej <br...@xbc.nu> writes:
>
>
>>As you might have guessed, given the last paragraph above, I don't agree
>>with putting this into libsvn_subr. It doesn't belong there. We need a
>>separate library that contains only utilities for our command-line
>>clients. There are other things that should go there; for instance,
>>svn_path_internal_style and svn_path_local_style don't belong in
>>libsvn_subr, nor does opt.c. I also strongly suspect that the
>>command-line client support library should _only_ exist as a static lib,
>>not a shared one. I'd suggest refactoring all this into a new directory
>>under subversion/clients.
>>
>>
>
>I think that's fine. Never meant to claim this is a good solution,
>just that it's better,
>
>to some of us :-),
>
/me lets fly a loud raspberry
> than the previous solution.
>
>However, we also have many more important fish to fry, so refactoring
>this isn't on the top of my personal stack either :-(.
>
>
Oh sure, I wasn't suggesting you should do that right now. I'd just like
to point out it's something to do. Maybe I'll file an issue.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Branko Čibej <br...@xbc.nu> writes:
> As you might have guessed, given the last paragraph above, I don't agree
> with putting this into libsvn_subr. It doesn't belong there. We need a
> separate library that contains only utilities for our command-line
> clients. There are other things that should go there; for instance,
> svn_path_internal_style and svn_path_local_style don't belong in
> libsvn_subr, nor does opt.c. I also strongly suspect that the
> command-line client support library should _only_ exist as a static lib,
> not a shared one. I'd suggest refactoring all this into a new directory
> under subversion/clients.
I think that's fine. Never meant to claim this is a good solution,
just that it's better, to some of us :-), than the previous solution.
However, we also have many more important fish to fry, so refactoring
this isn't on the top of my personal stack either :-(.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include
libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion
Posted by Branko Čibej <br...@xbc.nu>.
Greg Hudson wrote:
>>I also strongly suspect that the command-line client support library
>>should _only_ exist as a static lib, not a shared one.
>>
>>
>
>Why? (As an argument against, I believe Debian has a policy against
>static-only libraries of any sort, though I've never determined why.)
>
>
I really couldn't care less about Debian policy. These functions are so
app-specific that I'd even rather have each command-line client compile
its own objects, so they'd share only source, not the libraries. I can
well imagine different clients having different defaults (for, say,
config settings and stuff).
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion
Posted by Colin Watson <cj...@flatline.org.uk>.
On Tue, Feb 11, 2003 at 02:58:46PM -0500, Greg Hudson wrote:
> On Tue, 2003-02-11 at 13:11, Branko ?ibej wrote:
> > I also strongly suspect that the command-line client support library
> > should _only_ exist as a static lib, not a shared one.
>
> Why? (As an argument against, I believe Debian has a policy against
> static-only libraries of any sort, though I've never determined why.)
It's just to maximize efficiency across the whole distribution, and it's
been relaxed recently for libraries which intentionally don't have a
stable interface. I don't think it was ever really intended that
application developers should be taking that recommendation without a
pinch of salt.
--
Colin Watson [cjwatson@flatline.org.uk]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include
libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve
svnversion
Posted by Greg Hudson <gh...@MIT.EDU>.
On Tue, 2003-02-11 at 13:11, Branko Čibej wrote:
> As you might have guessed, given the last paragraph above, I don't agree
> with putting this into libsvn_subr. It doesn't belong there. We need a
> separate library that contains only utilities for our command-line
> clients. There are other things that should go there; for instance,
> svn_path_internal_style and svn_path_local_style don't belong in
> libsvn_subr, nor does opt.c.
It would be neat to have a library which wraps libsvn_client and:
* Accepts strings in the native charset
* Accepts non-canonicalized paths
* Doesn't use pool arguments (it would use a context, and would use a
subpool per operation, which is okay because the libsvn_client
operations are large-grain)
* Can contain initialization functions like this one
In general, we would be aiming for the simplest possible interface for
applications. My only concern is that applications would eventually
need to probe into the regular libraries like libsvn_wc, and now they
need pools and charset conversion and path canonicalization again (and
only for those calls, which is confusing).
> I also strongly suspect that the command-line client support library
> should _only_ exist as a static lib, not a shared one.
Why? (As an argument against, I believe Debian has a policy against
static-only libraries of any sort, though I've never determined why.)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org