You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by Andrey Morskoy <mo...@ciklum.com> on 2017/02/24 10:35:08 UTC
How counters are actually filled in a source
Could you please explain a code pattern for situation:
In a data-stream-recvr.cc there is section:
buffer_full_wall_timer_ = ADD_TIMER(profile_, "SendersBlockedTimer");
But I could not find the code section responsible for increment this timer.
Thanks
Re: How counters are actually filled in a source
Posted by Henry Robinson <he...@cloudera.com>.
The timer is added to the runtime profile by ADD_TIMER(), and incremented
by CANCEL_SAFE_SCOPED_TIMER(), as Andrey said. What's the issue you're
seeing?
On 7 March 2017 at 23:13, Jim Apple <jb...@cloudera.com> wrote:
> I don't see any other user of this either. Feel free to file a JIRA on
> this, and, if you like, a patch:
> https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala
>
> On Fri, Feb 24, 2017 at 3:12 AM, Andrey Morskoy <mo...@ciklum.com> wrote:
>
> > Seems that's it:
> > DataStreamRecvr::SenderQueue::AddBatch:
> > if (timer_lock) {
> > CANCEL_SAFE_SCOPED_TIMER(recvr_->buffer_full_wall_timer_,
> > &is_cancelled_);
> > ....
> >
> > On Fri, Feb 24, 2017 at 12:35 PM, Andrey Morskoy <mo...@ciklum.com>
> wrote:
> >
> > > Could you please explain a code pattern for situation:
> > > In a data-stream-recvr.cc there is section:
> > > buffer_full_wall_timer_ = ADD_TIMER(profile_, "SendersBlockedTimer");
> > >
> > >
> > > But I could not find the code section responsible for increment this
> > > timer. Thanks
> > >
> > >
> >
>
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
Re: How counters are actually filled in a source
Posted by Jim Apple <jb...@cloudera.com>.
I don't see any other user of this either. Feel free to file a JIRA on
this, and, if you like, a patch:
https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala
On Fri, Feb 24, 2017 at 3:12 AM, Andrey Morskoy <mo...@ciklum.com> wrote:
> Seems that's it:
> DataStreamRecvr::SenderQueue::AddBatch:
> if (timer_lock) {
> CANCEL_SAFE_SCOPED_TIMER(recvr_->buffer_full_wall_timer_,
> &is_cancelled_);
> ....
>
> On Fri, Feb 24, 2017 at 12:35 PM, Andrey Morskoy <mo...@ciklum.com> wrote:
>
> > Could you please explain a code pattern for situation:
> > In a data-stream-recvr.cc there is section:
> > buffer_full_wall_timer_ = ADD_TIMER(profile_, "SendersBlockedTimer");
> >
> >
> > But I could not find the code section responsible for increment this
> > timer. Thanks
> >
> >
>
Re: How counters are actually filled in a source
Posted by Andrey Morskoy <mo...@ciklum.com>.
Seems that's it:
DataStreamRecvr::SenderQueue::AddBatch:
if (timer_lock) {
CANCEL_SAFE_SCOPED_TIMER(recvr_->buffer_full_wall_timer_,
&is_cancelled_);
....
On Fri, Feb 24, 2017 at 12:35 PM, Andrey Morskoy <mo...@ciklum.com> wrote:
> Could you please explain a code pattern for situation:
> In a data-stream-recvr.cc there is section:
> buffer_full_wall_timer_ = ADD_TIMER(profile_, "SendersBlockedTimer");
>
>
> But I could not find the code section responsible for increment this
> timer. Thanks
>
>