You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/29 06:57:10 UTC

[GitHub] [incubator-superset] junlincc edited a comment on pull request #11459: fix: disabled caret change from left to right

junlincc edited a comment on pull request #11459:
URL: https://github.com/apache/incubator-superset/pull/11459#issuecomment-718402598


   Sortby, Metrics and Filters popovers all have caret. We will likely to remove them
   to get closer to SIP 34. will address them while we work on reorganizing
   the control panel.
   
   On Wed, Oct 28, 2020 at 10:15 PM Maxime Beauchemin <no...@github.com>
   wrote:
   
   > This works, but I thought the conversation was about fully removing the
   > caret to align with our other label+popovers pattern.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-superset/pull/11459#issuecomment-718364535>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AQFR5U3IF6GJHTFSAF4HZFLSND255ANCNFSM4TCSW5YA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org