You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/04/02 06:12:47 UTC
[PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
kou opened a new pull request, #46006:
URL: https://github.com/apache/arrow/pull/46006
### Rationale for this change
TODO
### What changes are included in this PR?
TODO
### Are these changes tested?
TODO
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2771435944
:warning: GitHub issue #45994 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2771503874
Revision: ef694f80b0e6819d6445397b6897f9d1dd1c6b11
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d0cbaec740](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d0cbaec740)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/14213363214/job/39824527508)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2772140685
Revision: 3a1fa832705a29cff171e7a4acec053eb9d6e3ef
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9299a363c7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9299a363c7)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/14217466027/job/39837360340)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46006:
URL: https://github.com/apache/arrow/pull/46006#discussion_r2028089565
##########
c_glib/vcpkg.json:
##########
@@ -1,23 +1,11 @@
{
"name": "arrow-glib",
"version-string": "20.0.0-SNAPSHOT",
+ "$comment:dependencies": "We can enable gobject-introspection again once it's updated",
Review Comment:
GLib is updated but GObject Introspection isn't updated in the latest vcpkg. So we can't use GObject Introspection for now.
##########
.github/workflows/ruby.yml:
##########
@@ -395,6 +395,20 @@ jobs:
env:
# We can invalidate the current cache by updating this.
CACHE_VERSION: "2024-05-09"
+ - name: Checkout vcpkg
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ fetch-depth: 0
+ path: vcpkg
+ repository: microsoft/vcpkg
+ - name: Bootstrap vcpkg
+ run: |
+ vcpkg\bootstrap-vcpkg.bat
+ $VCPKG_ROOT = $(Resolve-Path -LiteralPath "vcpkg").ToString()
+ Write-Output ${VCPKG_ROOT} | `
+ Out-File -FilePath ${Env:GITHUB_PATH} -Encoding utf8 -Append
+ Write-Output "VCPKG_ROOT=${VCPKG_ROOT}" | `
+ Out-File -FilePath ${Env:GITHUB_ENV} -Encoding utf8 -Append
Review Comment:
Ensure using the latest vcpkg. vcpkg exists in GitHub Actions runner by default. But it may be older than vcpkg we want to use.
##########
c_glib/meson.build:
##########
@@ -97,47 +98,96 @@ else
endif
if arrow_cpp_build_lib_dir == ''
- arrow = dependency('arrow', version: ['>=' + version])
+ common_args = {'version': [f'>=@version_no_snapshot@']}
+ arrow = dependency(
+ 'arrow',
+ 'Arrow',
Review Comment:
This is for detecting a package for CMake.
##########
c_glib/meson.build:
##########
@@ -81,7 +82,7 @@ endif
generate_vapi = have_gi and get_option('vapi')
if generate_vapi
pkgconfig_variables += ['vapidir=@0@'.format(vapi_dir)]
- add_languages('vala')
+ add_languages('vala', native: false)
Review Comment:
This is not required but it reports a warning.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1667,11 +1667,10 @@ endif()
if(ARROW_BUILD_TESTS
OR ARROW_BUILD_BENCHMARKS
OR ARROW_BUILD_INTEGRATION
- OR ARROW_USE_GLOG
- OR ARROW_WITH_GRPC)
- set(ARROW_NEED_GFLAGS 1)
Review Comment:
Bundled gRPC doesn't need gflags.
This is not required because we use gflags provided by vcpkg. (This was needed before vcpkg adds CMake 4.0.0 workaround.)
##########
c_glib/meson.build:
##########
@@ -97,47 +98,96 @@ else
endif
if arrow_cpp_build_lib_dir == ''
- arrow = dependency('arrow', version: ['>=' + version])
+ common_args = {'version': [f'>=@version_no_snapshot@']}
+ arrow = dependency(
+ 'arrow',
+ 'Arrow',
+ kwargs: common_args,
+ modules: ['Arrow::arrow_shared'],
Review Comment:
This is for detecting a package for CMake.
##########
cpp/CMakeLists.txt:
##########
@@ -532,22 +532,79 @@ enable_testing()
# For arrow.pc. Cflags.private, Libs.private and Requires.private are
# used when "pkg-config --cflags --libs --static arrow" is used.
set(ARROW_PC_CFLAGS "")
-set(ARROW_PC_CFLAGS_PRIVATE " -DARROW_STATIC")
+set(ARROW_PC_CFLAGS_PRIVATE "")
+if(ARROW_BUILD_STATIC)
+ # We add -DARROW_STATIC only when static build is enabled because
+ # pkgconf 1.7.4 or later on Windows uses "--static" by default. If
+ # Cflags.private (-DARROW_STATIC) is used for shared linking, it
+ # will cause linke error. We recommend users to not use pkgconf for
+ # shared linking on Windows but we also provide a workaround here.
+ # If users don't enable ARROW_BUILD_STATIC, users can use pkgconf on
+ # Windows because Cflags.private is used but it has nothing.
+ string(APPEND ARROW_PC_CFLAGS_PRIVATE " -DARROW_STATIC")
Review Comment:
This is a workaround for recent pkgconf on Windows. Our CI doesn't use `-DARROW_BUILD_STATIC=ON`.
##########
.github/workflows/ruby.yml:
##########
@@ -411,10 +425,14 @@ jobs:
- name: Build C++
shell: cmd
run: |
+ set VCPKG_ROOT_KEEP=%VCPKG_ROOT%
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
Review Comment:
This overrides `VCPKG_ROOT`. So we need to restore our `VCPKG_ROOT` after this.
##########
ci/scripts/c_glib_build.sh:
##########
@@ -65,9 +67,10 @@ fi
# Build with Meson
meson setup \
--backend=ninja \
- --prefix="${ARROW_HOME}" \
+ --cmake-prefix-path="${meson_cmake_prefix_path}" \
Review Comment:
This is for finding CMake packages of Apache Arrow C++.
##########
cpp/vcpkg.json:
##########
@@ -29,15 +29,19 @@
"gflags",
"glog",
{
- "name":"google-cloud-cpp",
- "version>=": "1.32.1",
+ "name": "google-cloud-cpp",
"default-features": false,
"features": [
"storage"
]
},
"grpc",
- "gtest",
+ {
+ "name": "gtest",
+ "features": [
+ "cxx17"
Review Comment:
We need this because vcpkg's gtest uses C++14 by default.
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -27,7 +27,6 @@ call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Too
@rem changes in vcpkg
vcpkg install ^
- --triplet x64-windows ^
Review Comment:
We use `VCPKG_DEFAULT_TRIPLET` env instead of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2775615529
OK!
This is the last error to be fixed:
https://github.com/apache/arrow/actions/runs/14237881729/job/39900817789?pr=46006#step:13:857
```text
FAILED: arrow-glib/arrow-glib-2000.dll arrow-glib/arrow-glib-2000.pdb
"link" /MACHINE:x64 /OUT:arrow-glib/arrow-glib-2000.dll arrow-glib/arrow-glib-2000.dll.p/meson-generated_.._enums.c.obj arrow-glib/arrow-glib-2000.dll.p/array-builder.cpp.obj arrow-glib/arrow-glib-2000.dll.p/basic-array.cpp.obj arrow-glib/arrow-glib-2000.dll.p/basic-data-type.cpp.obj arrow-glib/arrow-glib-2000.dll.p/buffer.cpp.obj arrow-glib/arrow-glib-2000.dll.p/chunked-array.cpp.obj arrow-glib/arrow-glib-2000.dll.p/codec.cpp.obj arrow-glib/arrow-glib-2000.dll.p/composite-array.cpp.obj arrow-glib/arrow-glib-2000.dll.p/composite-data-type.cpp.obj arrow-glib/arrow-glib-2000.dll.p/datum.cpp.obj arrow-glib/arrow-glib-2000.dll.p/decimal.cpp.obj arrow-glib/arrow-glib-2000.dll.p/decoder.cpp.obj arrow-glib/arrow-glib-2000.dll.p/error.cpp.obj arrow-glib/arrow-glib-2000.dll.p/expression.cpp.obj arrow-glib/arrow-glib-2000.dll.p/field.cpp.obj arrow-glib/arrow-glib-2000.dll.p/interval.cpp.obj arrow-glib/arrow-glib-2000.dll.p/memory-pool.cpp.obj arrow-glib/arrow-glib-2000.dll.p/record-batch.c
pp.obj arrow-glib/arrow-glib-2000.dll.p/scalar.cpp.obj arrow-glib/arrow-glib-2000.dll.p/schema.cpp.obj arrow-glib/arrow-glib-2000.dll.p/table-builder.cpp.obj arrow-glib/arrow-glib-2000.dll.p/table.cpp.obj arrow-glib/arrow-glib-2000.dll.p/tensor.cpp.obj arrow-glib/arrow-glib-2000.dll.p/timestamp-parser.cpp.obj arrow-glib/arrow-glib-2000.dll.p/type.cpp.obj arrow-glib/arrow-glib-2000.dll.p/file-mode.cpp.obj arrow-glib/arrow-glib-2000.dll.p/file.cpp.obj arrow-glib/arrow-glib-2000.dll.p/input-stream.cpp.obj arrow-glib/arrow-glib-2000.dll.p/output-stream.cpp.obj arrow-glib/arrow-glib-2000.dll.p/readable.cpp.obj arrow-glib/arrow-glib-2000.dll.p/writable-file.cpp.obj arrow-glib/arrow-glib-2000.dll.p/writable.cpp.obj arrow-glib/arrow-glib-2000.dll.p/ipc-options.cpp.obj arrow-glib/arrow-glib-2000.dll.p/metadata-version.cpp.obj arrow-glib/arrow-glib-2000.dll.p/reader.cpp.obj arrow-glib/arrow-glib-2000.dll.p/writer.cpp.obj arrow-glib/arrow-glib-2000.dll.p/compute.cpp.obj arrow-glib/arrow-glib-2
000.dll.p/file-system.cpp.obj arrow-glib/arrow-glib-2000.dll.p/local-file-system.cpp.obj "/release" "/nologo" "/DEBUG" "/PDB:arrow-glib\arrow-glib-2000.pdb" "/DLL" "/IMPLIB:arrow-glib\arrow-glib.lib" "D:/a/arrow/arrow/dist/lib/arrow.lib" "D:/a/arrow/arrow/dist/lib/arrow_acero.lib" "D:/a/arrow/arrow/build/vcpkg_installed/x64-windows/lib/gobject-2.0.lib" "D:/a/arrow/arrow/build/vcpkg_installed/x64-windows/lib/glib-2.0.lib" "D:/a/arrow/arrow/build/vcpkg_installed/x64-windows/lib/intl.lib" "D:/a/arrow/arrow/build/vcpkg_installed/x64-windows/lib/iconv.lib" "/LIBPATH:D:/a/arrow/arrow/build/vcpkg_installed/x64-windows/lib" "ws2_32.lib" "winmm.lib" "D:/a/arrow/arrow/build/vcpkg_installed/x64-windows/lib/gio-2.0.lib" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib"
Creating library arrow-glib\arrow-glib.lib and object arrow-glib\arrow-glib.exp
array-builder.cpp.obj : error LNK2019: unresolved external symbol "const arrow::AdaptiveUIntBuilder::`vftable'" (??_7AdaptiveUIntBuilder@arrow@@6B@) referenced in function "public: __cdecl arrow::AdaptiveUIntBuilder::AdaptiveUIntBuilder(class arrow::MemoryPool *)" (??0AdaptiveUIntBuilder@arrow@@QEAA@PEAVMemoryPool@1@@Z)
array-builder.cpp.obj : error LNK2019: unresolved external symbol "const arrow::AdaptiveIntBuilder::`vftable'" (??_7AdaptiveIntBuilder@arrow@@6B@) referenced in function "public: __cdecl arrow::AdaptiveIntBuilder::AdaptiveIntBuilder(class arrow::MemoryPool *,__int64)" (??0AdaptiveIntBuilder@arrow@@QEAA@PEAVMemoryPool@1@_J@Z)
```
I think that we can fix it by using correct build configurations not changing existing code but I haven't found it yet... I think that I can fix this tomorrow...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2775598674
Let me know if this is ready for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2771783367
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2784065430
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3351aebc357ea48a147956de1ededf1a234858b0.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/40120578115) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2771499608
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2772168215
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2774572738
Revision: bce42569f0d39cf4d61f7897ed056719cd4622d1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f7db796acc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f7db796acc)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/14235985950/job/39895251958)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #46006:
URL: https://github.com/apache/arrow/pull/46006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2774569603
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2772135278
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2772173395
Revision: 0da9d24287faecf9344c4e59e9434cf1f1128fad
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c457f813ed](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c457f813ed)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/14217728704/job/39838177373)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2771790033
Revision: 368e3f935778094c6f00ac0947d8945b87cf773b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-daae361644](https://github.com/ursacomputing/crossbow/branches/all?query=actions-daae361644)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/14214986672/job/39829527046)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2771435932
:warning: GitHub issue #45994 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2777552649
@assignUser This is ready but there are many changes I thought...
See the PR description for summary of changes.
There were some problems to be fixed:
* We need to use recent vcpkg to use Boost's CMake package (this was done by #45623)
* We need to fix the followings to use recent vcpkg:
* GLib is buildable only with the very recent vcpkg
* CMake 4.0.0 workaround (this is needed for gflags) is only available with the very recent vcpkg
* pkgconf and our `.pc` aren't good pair for shared linking on Windows (I don't know why it didn't cause a link problem with old vcpkg we used... I think that pkgconf in the old vcpkg still has this problem...)
This PR fixes all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2774815750
Revision: 65846529f86802111f23db1fe143b1b3df41cb62
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d3b542bf37](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d3b542bf37)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/14237989273/job/39901146467)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45994: [CI][GLib] Fix vcpkg configuration for Windows job [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46006:
URL: https://github.com/apache/arrow/pull/46006#issuecomment-2774808937
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org