You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "wenjin272 (via GitHub)" <gi...@apache.org> on 2025/12/02 02:57:11 UTC
[PR] [runtime] Implement hashCode and equals for ActionTask. [flink-agents]
wenjin272 opened a new pull request, #365:
URL: https://github.com/apache/flink-agents/pull/365
<!--
* Thank you very much for contributing to Flink Agents.
* Please add the relevant components in the PR title. E.g., [api], [runtime], [java], [python], [hotfix], etc.
-->
<!-- Please link the PR to the relevant issue(s). Hotfix doesn't need this. -->
Linked issue: #340
### Purpose of change
Implement `hashCode` and `equals` for ActionTask, to resolve the question that python action async execution can not work with rocksdb.
### Tests
it
### API
No
### Documentation
<!-- Do not remove this section. Check the proper box only. -->
- [ ] `doc-needed` <!-- Your PR changes impact docs -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runtime] Implement hashCode and equals for ActionTask. [flink-agents]
Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan merged PR #365:
URL: https://github.com/apache/flink-agents/pull/365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runtime] Implement hashCode and equals for ActionTask. [flink-agents]
Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan commented on code in PR #365:
URL: https://github.com/apache/flink-agents/pull/365#discussion_r2579677930
##########
runtime/src/main/java/org/apache/flink/agents/runtime/python/event/PythonEvent.java:
##########
@@ -55,4 +57,17 @@ public byte[] getEvent() {
public String getEventType() {
return eventType;
}
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
We should also invoke the `super().equals()`
Same for the hashcode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runtime] Implement hashCode and equals for ActionTask. [flink-agents]
Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 commented on PR #365:
URL: https://github.com/apache/flink-agents/pull/365#issuecomment-3600006741
Hi, @Sxnan, please help take a look this pr, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org