[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #1766: TPC-H benchmark can optionally write JSON output file with benchmark summary

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #1766:
URL: https://github.com/apache/arrow-datafusion/pull/1766#discussion_r800393568



##########
File path: benchmarks/src/bin/tpch.rs
##########
@@ -359,6 +386,27 @@ async fn benchmark_ballista(opt: BallistaBenchmarkOpt) -> Result<()> {
     let avg = millis.iter().sum::<f64>() / millis.len() as f64;
     println!("Query {} avg time: {:.2} ms", opt.query, avg);
 
+    if let Some(path) = &opt.output_path {
+        write_summary_json(&mut benchmark_run, path)?;
+    }
+
+    Ok(())
+}
+
+fn write_summary_json(benchmark_run: &mut BenchmarkRun, path: &PathBuf) -> Result<()> {

Review comment:
       ```suggestion
   fn write_summary_json(benchmark_run: &mut BenchmarkRun, path: &Path) -> Result<()> {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org