You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/01 23:52:39 UTC

[GitHub] [airflow] bingqinzhou commented on a change in pull request #13980: update BigQueryUpsertTableOperator class to support CMEK

bingqinzhou commented on a change in pull request #13980:
URL: https://github.com/apache/airflow/pull/13980#discussion_r568080601



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1912,8 +1920,11 @@ def __init__(
         self.gcp_conn_id = gcp_conn_id
         self.delegate_to = delegate_to
         self.location = location
+        self.encryption_configuration = encryption_configuration

Review comment:
       Would it be better to just pass `encryption_configuration` into `self.table_resource` instead of needing to define `self.encryption_configuration` here? 
   
   Something like: ```self.table_resource['encryptionConfiguration'] = encryption_configuration```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org