You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2021/02/04 12:00:05 UTC
[jira] [Updated] (RATIS-1306) Eliminate duplicated GitHub Actions
workflow
[ https://issues.apache.org/jira/browse/RATIS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Doroszlai updated RATIS-1306:
------------------------------------
Description:
GitHub Actions workflows for Ratis CI have two flavors: post-commit and pull-request. The main difference between the two is that Sonar is not updated for PRs:
{code}
- - run: ./dev-support/checks/sonar.sh
- if: github.repository == 'apache/incubator-ratis'
- env:
- SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
{code}
Similar to HDDS-3822, we can keep only the post-commit definition and execute {{sonar.sh}} conditionally.
The other difference is missing {{Summary of failures}} in the post-commit workflow, but it can be added.
was:
GitHub Actions workflows for Ratis CI have two flavors: post-commit and pull-request. The only difference between the two is that Sonar is not updated for PRs:
{code}
- - run: ./dev-support/checks/sonar.sh
- if: github.repository == 'apache/incubator-ratis'
- env:
- SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
{code}
Similar to HDDS-3822, we can keep only the post-commit definition and execute {{sonar.sh}} conditionally.
> Eliminate duplicated GitHub Actions workflow
> --------------------------------------------
>
> Key: RATIS-1306
> URL: https://issues.apache.org/jira/browse/RATIS-1306
> Project: Ratis
> Issue Type: Improvement
> Components: build
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
>
> GitHub Actions workflows for Ratis CI have two flavors: post-commit and pull-request. The main difference between the two is that Sonar is not updated for PRs:
> {code}
> - - run: ./dev-support/checks/sonar.sh
> - if: github.repository == 'apache/incubator-ratis'
> - env:
> - SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
> - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
> {code}
> Similar to HDDS-3822, we can keep only the post-commit definition and execute {{sonar.sh}} conditionally.
> The other difference is missing {{Summary of failures}} in the post-commit workflow, but it can be added.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)