You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/28 15:56:12 UTC
[GitHub] [camel-website] squakez commented on a diff in pull request #928: fix: og:image
squakez commented on code in PR #928:
URL: https://github.com/apache/camel-website/pull/928#discussion_r1033722581
##########
layouts/partials/header.html:
##########
@@ -31,11 +31,11 @@
<meta property="og:type" content="website">
{{ $featured := (.Resources.ByType "image").GetMatch "*featured*" }}
{{ with $featured }}
- <meta property="og:image" content="{{ $featured.RelPermalink }}">
+ <meta property="og:image" content="https://camel.apache.org{{ $featured.RelPermalink }}">
Review Comment:
@zregvart I finally made some test and your solution looks good. Do you know if there is some property on the `$featured` image to directly get the full url by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org