You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by govind-menon <gi...@git.apache.org> on 2018/10/01 00:32:40 UTC

[GitHub] storm pull request #2854: STORM-3239: Adding dumpjstack action and removing ...

GitHub user govind-menon opened a pull request:

    https://github.com/apache/storm/pull/2854

    STORM-3239: Adding dumpjstack action and removing wrong timeout param…

    …eter

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/govind-menon/storm STORM-3239

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2854
    
----
commit 954c810e150971e94219ec192f16fdd7d772d8df
Author: Govind Menon <go...@...>
Date:   2018-10-01T00:30:23Z

    STORM-3239: Adding dumpjstack action and removing wrong timeout parameter

----


---

[GitHub] storm pull request #2854: STORM-3239: Adding dumpjstack action and removing ...

Posted by agresch <gi...@git.apache.org>.

Github user agresch commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2854#discussion_r221626099
  
    --- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
    @@ -2165,21 +2165,20 @@ public static String getWorkerDumpLink(String host, long port, String topologyId
          * @param client client
          * @param id id
          * @param hostPort hostPort
    -     * @param timeout timeout
    +     * @param timestamp timestamp
          * @param config config
          * @param profileAction profileAction
          * @throws TException TException
          */
         public static void getTopologyProfilingAction(
                 Nimbus.Iface client, String id,
    -            String hostPort, String timeout, Map<String,
    +            String hostPort, Long timestamp, Map<String,
    --- End diff --
    
    It's confusing to me the purpose of the timestamp.  What does 0 vs current time vs future time indicate?  


---

[GitHub] storm pull request #2854: STORM-3239: Adding dumpjstack action and removing ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2854


---