You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jo...@apache.org on 2015/10/14 14:30:56 UTC

[2/6] mesos git commit: CMake:[1/3] Prepared stout tests to run with `make check`.

CMake:[1/3] Prepared stout tests to run with `make check`.

Right now running the Mesos tests from the default tests target will
(1) aggregate all our tests into a semi-useless report that hides all
the errors, and (2) strip all our colors when you do pass the verbosity
flag to get rid of the "report" structure.

This commit will prepare us to run the tests with with color, without
this default reporting structure. We do this by moving the tests target
to a `CACHE STRING` which can be referenced by the tests.

Review: https://reviews.apache.org/r/39091


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f4636a72
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f4636a72
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f4636a72

Branch: refs/heads/master
Commit: f4636a72954be4c1601b889513357d1e680b830e
Parents: bfdd376
Author: Alex Clemmer <cl...@gmail.com>
Authored: Wed Oct 14 14:01:19 2015 +0200
Committer: Joris Van Remoortere <jo...@gmail.com>
Committed: Wed Oct 14 14:24:57 2015 +0200

----------------------------------------------------------------------
 .../libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake    | 4 ++++
 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt          | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/f4636a72/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake b/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake
index c4d1b7b..acc6e02 100644
--- a/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake
+++ b/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake
@@ -14,6 +14,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+set(
+  STOUT_TESTS_TARGET stout_tests
+  CACHE STRING "Target we use to refer to tests for the stout library")
+
 if (NOT WIN32)
   # TODO(hausdorff): (cf. MESOS-3181) Add support for attempting to find these
   # packages on Windows, and then if that fails, use CMake macros/functions to

http://git-wip-us.apache.org/repos/asf/mesos/blob/f4636a72/3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt b/3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt
index 94292f8..0020715 100644
--- a/3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt
+++ b/3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt
@@ -14,8 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-set(STOUT_TESTS_TARGET stout_tests)
-
 # STOUT TESTS.
 ##############
 set(STOUT_TESTS_SRC