You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/08/02 08:22:18 UTC
[jira] Created: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
[classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
--------------------------------------------------------------------------------------------------------------
Key: HARMONY-1040
URL: http://issues.apache.org/jira/browse/HARMONY-1040
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Andrew Zhang
java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
Following test reproduces the bug:
public void test_hostEquals() throws Exception {
MockURLStreamHandler mockHandler = new MockURLStreamHandler();
URL u1 = new URL("http://andrew1");
URL u2 = new URL("http://andrew2");
assertTrue(mockHandler.hostEquals(u1, u2));
}
Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
The test passes against RI while fails against Harmony.
I'll upload a patch to fix this problem soon.
Thanks!
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Andrew Zhang updated HARMONY-1040:
----------------------------------
Attachment: Harmony-1040.diff
Hi Paulex,
Would you please try Harmony-1040.diff?
The updated patch includes:
1. Fix hostEquals bug.
2. Add a regression test in URLTest.java
3. Add Generic support for URLTest.java
Thanks!
Best regards,
Andrew
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1040.diff, luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Paulex Yang updated HARMONY-1040:
---------------------------------
Comment: was deleted
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1040.diff, luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=comments#action_12426109 ]
Paulex Yang commented on HARMONY-1040:
--------------------------------------
Jimmy, I cannot compile instrument module after appling this patch, seems it has dependency on other new classes(ClassFileTransformer or so) of this module?
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1040.diff, luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Paulex Yang closed HARMONY-1040.
--------------------------------
Verified by Andrew.
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1040.diff, luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Paulex Yang reassigned HARMONY-1040:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Paulex Yang resolved HARMONY-1040.
----------------------------------
Resolution: Fixed
Andrew, patch applied at revision r428264, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Andrew Zhang updated HARMONY-1040:
----------------------------------
Attachment: luni.diff
Hi,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Paulex Yang resolved HARMONY-1040.
----------------------------------
Resolution: Fixed
Andrew, patch applied at revision r429247, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1040.diff, luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=comments#action_12426229 ]
Andrew Zhang commented on HARMONY-1040:
---------------------------------------
Hi Paulex,
The fix looks fine, thanks a lot!
Best regards,
Andrew
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1040.diff, luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (HARMONY-1040) [classlib][luni]
java.net.URLStreamHandler.hostEquals should return true when two urls have
the same host ip.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1040?page=all ]
Paulex Yang reopened HARMONY-1040:
----------------------------------
the original patch caused 2 security module tests fail
> [classlib][luni] java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1040
> URL: http://issues.apache.org/jira/browse/HARMONY-1040
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff
>
>
> java.net.URLStreamHandler.hostEquals should return true when two urls have the same host ip.
> Following test reproduces the bug:
> public void test_hostEquals() throws Exception {
> MockURLStreamHandler mockHandler = new MockURLStreamHandler();
> URL u1 = new URL("http://andrew1");
> URL u2 = new URL("http://andrew2");
> assertTrue(mockHandler.hostEquals(u1, u2));
> }
> Configure andrew1,andrew2 as the same ip in hosts file(i.e. /etc/hosts for linux and WINDOWS\system32\drivers\etc for windows).
> The test passes against RI while fails against Harmony.
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira