[jira] [Commented] (PHOENIX-5121) Move unnecessary sorting and fetching out of loop

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760428#comment-16760428 ] 

Hadoop QA commented on PHOENIX-5121:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12957565/PHOENIX-5121.patch
  against master branch at commit 2ace9051c3d01dc599ba6b1a362ec7f84500efa5.
  ATTACHMENT ID: 12957565

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.schema.stats.NoOpStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2302//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2302//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2302//console

This message is automatically generated.

> Move unnecessary sorting and fetching out of loop
> -------------------------------------------------
>
>                 Key: PHOENIX-5121
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5121
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Aman Poonia
>            Assignee: Aman Poonia
>            Priority: Minor
>         Attachments: PHOENIX-5121.patch
>
>
> Don't fetch and sort PK columns of a table inside loop in PhoenixDatabaseMetaData#getPrimaryKeys



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)