You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/27 20:24:06 UTC
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1055: fix: joins on TimestampMillisecond columns
alamb commented on a change in pull request #1055:
URL: https://github.com/apache/arrow-datafusion/pull/1055#discussion_r717018294
##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -781,7 +782,7 @@ fn equal_rows(
DataType::Float32 => equal_rows_elem!(Float32Array, l, r, left, right),
DataType::Float64 => equal_rows_elem!(Float64Array, l, r, left, right),
DataType::Timestamp(_, None) => {
- equal_rows_elem!(Int64Array, l, r, left, right)
+ equal_rows_elem!(TimestampNanosecondArray, l, r, left, right)
Review comment:
FWIW it is possible to have `Timestamp(TimeUnit::Millisecond)` (and other units) in DataFusion if you feed the data directly from an Arrow array.
This table is for the types that are expressible in SQL (via a `CAST` statement, for example) and don't represent the full range of types that are possible to see in DataFusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org