You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/05/12 19:59:06 UTC
[GitHub] [helix] micahstubbs opened a new issue, #2092: upgrade helix-front to Angular 9.1
micahstubbs opened a new issue, #2092:
URL: https://github.com/apache/helix/issues/2092
https://update.angular.io/?l=3&v=8.2-9.1
see:
- #2088 for the 8.2 upgrade
- #2084 for the 7.2 upgrade
- #2053 for motivation, details, and history.
<img width="612" alt="Screen Shot 2022-05-12 at 12 58 36 PM" src="https://user-images.githubusercontent.com/2119400/168158066-dd6fcc6d-75c0-4ed4-9aeb-ec572fab0669.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125385263
We see a few actions we need to take based on these logs:
```py
Package "tsickle" has an incompatible peer dependency to
"typescript" (requires "~3.5.3", would install "3.8.3").
```
```py
❯ ModuleWithProviders migration.
In Angular 9, the ModuleWithProviders type without a generic has been deprecated.
This migration adds the generic where it is missing.
Read more about this here: https://v9.angular.io/guide/migration-module-with-providers
Could not migrate all instances of ModuleWithProviders
Please manually fix the following failures:
⮑ client/app/app-routing.module.ts@148:14: Type is not statically analyzable.
Migration completed.
No changes to commit after migration.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1126451451
🎉 build successful
```py
npm run build
> helix-front@1.2.1 build /helix/helix-front
> rm -rf dist && mkdir dist && ng build --aot --prod && tsc -p server
Generating ES5 bundles for differential loading...
ES5 bundle generation complete.
chunk {0} runtime-es2015.0dae8cbc97194c7caed4.js (runtime) 1.45 kB [entry] [rendered]
chunk {0} runtime-es5.0dae8cbc97194c7caed4.js (runtime) 1.45 kB [entry] [rendered]
chunk {2} polyfills-es2015.5f609f3a45acf61c5516.js (polyfills) 72.9 kB [initial] [rendered]
chunk {3} polyfills-es5.37963c72e258c43b9fb8.js (polyfills-es5) 166 kB [initial] [rendered]
chunk {1} main-es2015.678e317952713d0c3cc5.js (main) 3.01 MB [initial] [rendered]
chunk {1} main-es5.678e317952713d0c3cc5.js (main) 3.17 MB [initial] [rendered]
chunk {4} styles.7cb77b61ea0f6a800d90.css (styles) 89.9 kB [initial] [rendered]
Date: 2022-05-13T20:27:35.303Z - Hash: 9b4f4b2b06b29a310a50 - Time: 121044ms
WARNING in budgets: Exceeded maximum budget for initial-es2015. Budget 500 kB was not met by 2.68 MB with a total of 3.17 MB.
WARNING in budgets: Exceeded maximum budget for initial-es5. Budget 500 kB was not met by 2.93 MB with a total of 3.42 MB.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125401382
```py
npm WARN @angular/flex-layout@8.0.0-beta.27 requires a peer of @angular/cdk@^8.0.0-rc.0
```
let's try:
```py
npm i @angular/flex-layout@9.0.0-beta.31
```
[blame](https://github.com/angular/flex-layout/blame/af92cb053eef8fdc908f5e357289e76d5ef0c8c4/package.json)
[tags](https://github.com/angular/flex-layout/tags)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125408974
```py
npm i
audited 2036 packages in 7.283s
93 packages are looking for funding
run `npm fund` for details
found 154 vulnerabilities (16 low, 65 moderate, 49 high, 24 critical)
run `npm audit fix` to fix them, or `npm audit` for details
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1126456546
```json
"budgets": [
{
"type": "initial",
"maximumWarning": "3503kb"
}
],
```
This will silence the bundle size warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125390812
Now let's fix other peer dep warnings:
```py
@swimlane/ngx-datatable@16.1.1 @angular/common@<9.0.0
@swimlane/ngx-datatable@16.1.1 @angular/core@<9.0.0
@swimlane/ngx-datatable@16.1.1 @angular/platform-browser@<9.0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125472647
## Bundle Size Warnings
WARNING in Exceeded maximum budget. All figures kB.
|file|budget|excess|total|
|---|---|---|---|
|client/app/history/history-list/history-list.component.scss|6|56.2|62.2|
|client/app/resource/resource-detail/resource-detail.component.scss|6|56.2|62.2|
|client/app/cluster/cluster-list/cluster-list.component.scss|6|56.3|62.3|
|client/app/shared/node-viewer/node-viewer.component.scss|6|56.5|62.5|
|client/app/shared/data-table/data-table.component.scss|6|56.3|62.3|
Let's improve the usefulness of this by specifying one budget of `500k` for the initial js needed to bootstrap the app.
```json
"budgets": [
{
"type": "initial",
"maximumWarning": "500kb"
}
],
```
https://angular.io/guide/build#configuring-size-budgets
p app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1126466639
Let's look at these test failures one by one.
```py
Failed: R3InjectorError(DynamicTestModule)[Angulartics2Piwik -> Angulartics2 -> RouterlessTracking -> RouterlessTracking]:
NullInjectorError: No provider for RouterlessTracking!
NullInjectorError: R3InjectorError(DynamicTestModule)[Angulartics2Piwik -> Angulartics2 -> RouterlessTracking -> RouterlessTracking]:
NullInjectorError: No provider for RouterlessTracking!
at NullInjector.push../node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js.NullInjector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:937:1)
at R3Injector.push../node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js.R3Injector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:11616:1)
at R3Injector.push../node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js.R3Injector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:11616:1)
at injectInjectorOnly (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:822:1)
at Module.ɵɵinject (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:827:1)
at Object.Angulartics2_Factory [as factory] (http://localhost:9876/_karma_webpack_/node_modules/angulartics2/__ivy_ngcc__/fesm5/angulartics2.js:139:102)
at R3Injector.push../node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js.R3Injector.hydrate (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:11788:1)
at R3Injector.push../node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js.R3Injector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:11605:1)
at injectInjectorOnly (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:822:1)
at Module.ɵɵinject (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:827:1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125405069
> Bound CSS styles and classes previously were applied with a "last change wins" strategy, but now follow a defined precedence. Learn more about [Styling Precedence](https://angular.io/guide/attribute-binding#styling-precedence).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125431729
Here are [the full logs](https://gist.github.com/micahstubbs/76c69c670e3319ffac9c06ff0985b133) from running `npm run build`. It fails with several errors. Let's work through each error here, one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 closed issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
NealSun96 closed issue #2092: upgrade helix-front to Angular 9.1
URL: https://github.com/apache/helix/issues/2092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125402859
Oooh this is a useful command:
```py
npm outdated
Package Current Wanted Latest Location
@angular-devkit/build-angular 0.901.15 0.901.15 13.3.5 helix-front
@angular/animations 9.1.13 9.1.13 13.3.7 helix-front
@angular/cdk 9.2.4 9.2.4 13.3.7 helix-front
@angular/cli 9.1.15 9.1.15 13.3.5 helix-front
@angular/common 9.1.13 9.1.13 13.3.7 helix-front
@angular/compiler 9.1.13 9.1.13 13.3.7 helix-front
@angular/compiler-cli 9.1.13 9.1.13 13.3.7 helix-front
@angular/core 9.1.13 9.1.13 13.3.7 helix-front
@angular/flex-layout 9.0.0-beta.31 9.0.0-beta.31 13.0.0-beta.38 helix-front
@angular/forms 9.1.13 9.1.13 13.3.7 helix-front
@angular/material 9.2.4 9.2.4 13.3.7 helix-front
@angular/platform-browser 9.1.13 9.1.13 13.3.7 helix-front
@angular/platform-browser-dynamic 9.1.13 9.1.13 13.3.7 helix-front
@angular/platform-server 9.1.13 9.1.13 13.3.7 helix-front
@angular/router 9.1.13 9.1.13 13.3.7 helix-front
@swimlane/ngx-charts 13.0.4 13.0.4 20.1.0 helix-front
@swimlane/ngx-datatable 17.1.0 17.1.0 20.0.0 helix-front
@swimlane/ngx-graph 7.0.0 7.2.0 8.0.0 helix-front
@types/hammerjs 2.0.35 2.0.41 2.0.41 helix-front
@types/jasmine 2.5.38 2.5.38 4.0.3 helix-front
@types/lodash 4.14.120 4.14.120 4.14.182 helix-front
@types/node 12.20.51 12.20.51 17.0.32 helix-front
@types/request 2.0.9 2.48.8 2.48.8 helix-front
ajv 6.9.1 6.12.6 8.11.0 helix-front
angulartics2 2.5.0 2.5.0 12.1.0 helix-front
body-parser 1.18.2 1.20.0 1.20.0 helix-front
codelyzer 5.2.2 5.2.2 6.0.2 helix-front
concurrently 3.5.1 3.6.1 7.1.0 helix-front
core-js 2.5.3 2.6.12 3.22.5 helix-front
d3-shape 1.3.7 1.3.7 3.1.0 helix-front
dotenv 4.0.0 4.0.0 16.0.1 helix-front
express-session 1.17.2 1.17.3 1.17.3 helix-front
jasmine-core 2.5.2 2.5.2 4.1.1 helix-front
jasmine-spec-reporter 3.2.0 3.2.0 7.0.0 helix-front
karma 1.4.1 1.4.1 6.3.19 helix-front
karma-chrome-launcher 2.0.0 2.0.0 3.1.1 helix-front
karma-cli 1.0.1 1.0.1 2.0.0 helix-front
karma-coverage-istanbul-reporter 0.2.3 0.2.3 3.0.3 helix-front
karma-jasmine 1.1.1 1.1.2 5.0.0 helix-front
karma-jasmine-html-reporter 0.2.2 0.2.2 1.7.0 helix-front
ldapjs 1.0.2 1.0.2 2.3.2 helix-front
lodash 4.17.15 4.17.21 4.17.21 helix-front
ngx-clipboard 12.1.2 12.3.1 15.1.0 helix-front
ngx-json-viewer 2.4.0 2.4.0 3.0.2 helix-front
ngx-vis 0.1.0 0.1.0 3.1.0 helix-front
nodemon 1.11.0 1.11.0 2.0.16 helix-front
protractor 5.1.2 5.1.2 7.0.0 helix-front
request 2.83.0 2.88.2 2.88.2 helix-front
rxjs 6.5.5 6.6.7 7.5.5 helix-front
ts-node 2.0.0 2.0.0 10.7.0 helix-front
tsickle 0.38.1 0.38.1 0.46.0 helix-front
tslib 1.14.1 1.14.1 2.4.0 helix-front
tslint 5.8.0 5.20.1 6.1.3 helix-front
typescript 3.8.3 3.8.3 4.6.4 helix-front
vis 4.21.0 4.21.0 4.21.0-EOL helix-front
zone.js 0.10.3 0.10.3 0.11.5 helix-front
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125403444
<img width="756" alt="Screen Shot 2022-05-12 at 1 41 11 PM" src="https://user-images.githubusercontent.com/2119400/168164282-502e93c9-5b5b-4faa-a414-5d6a7e828808.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125405939
> If you use `ngForm` element selector to create Angular Forms, you should instead use `ng-form`.
We used this in two places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125378444
Now let's try:
`NG_DISABLE_VERSION_CHECK=1 npx @angular/cli@8 update @angular/core@8 @angular/cli@8 --create-commits`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125477457
### ngx-vis: not compatible with Angular Ivy
```py
ERROR in node_modules/ngx-vis/ngx-vis.d.ts:2:22 - error NG6002:
# Appears in the NgModule.imports of DashboardModule,
# but could not be resolved to an NgModule class.
# This likely means that the library (ngx-vis)
# which declares VisModule has not been processed correctly by ngcc,
# or is not compatible with Angular Ivy.
# Check if a newer version of the library is available, and update if so.
# Also consider checking with the library's authors
# to see if the library is expected to be compatible with Ivy.
2 export declare class VisModule {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125408581
Let's test the upgrade from Angular 8.2 to Angular 9.1.
- [ ] `npm install` works
- [ ] `npm rm type:check:watch` shows 0 TypeScript errors
- [ ] `npm run lint` runs and passes `All files pass linting.`
- [ ] `npm run build` works
- [ ] `npm start` works, with 0 errors in the browser console.
- [ ] `npm run test` runs and passes.
`npm start` works as expected, and recognizes our proxy config in `proxy.conf.json`.
Helix UI renders with 0 errors and 1 warning in the browser console. The warning is understandable since the piwik telemetry library is not configured.
`npm run test` results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125406355
> We have updated the `tsconfig.app.json` to limit the files compiled. If you rely on other files being included in the compilation, such as a `typings.d.ts` file, you need to manually add it to the compilation.
It doesn't look like this applies to us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125406772
> With Angular 9 Ivy is now the default rendering engine, for any compatibility problems that might arise, read the [Ivy compatibility guide](https://angular.io/guide/ivy-compatibility).
This may cause problems. Let's test and see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125486970
Ah hah! We have a new error. It seems there are breaking changes in `ngx-vis`.
```ts
ERROR in client/app/dashboard/dashboard.component.ts:13:10 - error TS2305:
Module '"../../../node_modules/ngx-vis/ngxvis"' has no exported member 'VisNode'.
13 import { VisNode, VisNodes, VisEdges, VisNetworkService, VisNetworkData, VisNetworkOptions } from 'ngx-vis';
~~~~~~~
client/app/dashboard/dashboard.component.ts:13:19 - error TS2305:
Module '"../../../node_modules/ngx-vis/ngxvis"' has no exported member 'VisNodes'.
13 import { VisNode, VisNodes, VisEdges, VisNetworkService, VisNetworkData, VisNetworkOptions } from 'ngx-vis';
~~~~~~~~
client/app/dashboard/dashboard.component.ts:13:29 - error TS2305:
Module '"../../../node_modules/ngx-vis/ngxvis"' has no exported member 'VisEdges'.
13 import { VisNode, VisNodes, VisEdges, VisNetworkService, VisNetworkData, VisNetworkOptions } from 'ngx-vis';
~~~~~~~~
client/app/dashboard/dashboard.component.ts:13:58 - error TS2305:
Module '"../../../node_modules/ngx-vis/ngxvis"' has no exported member 'VisNetworkData'.
13 import { VisNode, VisNodes, VisEdges, VisNetworkService, VisNetworkData, VisNetworkOptions } from 'ngx-vis';
~~~~~~~~~~~~~~
client/app/dashboard/dashboard.component.ts:13:74 - error TS2305:
Module '"../../../node_modules/ngx-vis/ngxvis"' has no exported member 'VisNetworkOptions'.
13 import { VisNode, VisNodes, VisEdges, VisNetworkService, VisNetworkData, VisNetworkOptions } from 'ngx-vis';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1126406709
It looks like we can refer to these diffs in the examples to figure out how to migrate our own code that uses the network drawing features of `ngx-vis`.
- https://github.com/visjs/ngx-vis/commit/1450a657df52ea1ca793848088d79be6f85e0eb1#diff-7b91b5fa8a752a0b4a91c70e2fe63d035c8787b3b1823c4012e4e013e3e2e2aa
- https://github.com/visjs/ngx-vis/commit/5c035af91b68a9bd3d94735d2108bb6149e25906#diff-7b91b5fa8a752a0b4a91c70e2fe63d035c8787b3b1823c4012e4e013e3e2e2aa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1126458329
Let's test the upgrade from Angular 8.2 to Angular 9.1.
- [x] `npm install` works
- [x] `npm rm type:check:watch` shows 0 TypeScript errors
- [x] `npm run lint` runs and passes `All files pass linting.`
- [x] `npm run build` works
- [ ] `npm start` works, with 0 errors in the browser console.
- [ ] `npm run test` runs and passes.
`npm start` works as expected, and recognizes our proxy config in `proxy.conf.json`.
Helix UI renders with 0 errors and 1 warning in the browser console. The warning is understandable since the piwik telemetry library is not configured.
`npm run test` results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125473776
### no ng-form directive found
```py
client/app/shared/dialog/input-dialog/input-dialog.component.html:20:43 - error NG8003:
# No directive found with exportAs 'ng-form'.
20 <form (ngSubmit)="onSubmit()" #inputForm="ng-form">
~~~~~~~
client/app/shared/dialog/input-dialog/input-dialog.component.ts:7:16
7 templateUrl: './input-dialog.component.html',
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error occurs in the template of component InputDialogComponent.
```
```py
client/app/shared/dialog/confirm-dialog/confirm-dialog.component.html:20:43 - error NG8003:
# No directive found with exportAs 'ng-form'.
20 <form (ngSubmit)="onCancel()" #inputForm="ng-form">
~~~~~~~
client/app/shared/dialog/confirm-dialog/confirm-dialog.component.ts:7:16
7 templateUrl: './confirm-dialog.component.html',
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error occurs in the template of component ConfirmDialogComponent.
```
---
https://stackoverflow.com/questions/39559296/typescript-s-angular-framework-error-there-is-no-directive-with-exportas-set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125394801
Now, let's update `@angular/material`:
```py
NG_DISABLE_VERSION_CHECK=1 npx @angular/cli@9 update @angular/material@9 --force
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125460340
## Deep Import Warning
Warning: Entry point 'angulartics2' contains deep imports into
```
/helix/helix-front/node_modules/rxjs/ReplaySubject
/helix/helix-front/node_modules/rxjs/add/operator/filter
```
This is probably not a problem, but may cause the compilation of entry points to be out of order.
---
```
npm i angulartics2@9.1.0
```
[blame](https://github.com/angulartics/angulartics2/blame/fe6c6dfe40c7bdd4d13dab8da7518851814d0723/package.json)
[commit](https://github.com/angulartics/angulartics2/commit/2af60495252a63faaca6902b2c3180513a48f567)
[tags](https://github.com/angulartics/angulartics2/tags)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125397898
Possible action items:
- [ ] Could not find TypeScript project for project: helix-front-e2e
- [ ] ⚠ General notice: The HammerJS v9 migration for Angular Components is not able to migrate tests. Please manually clean up tests in your project if they rely on HammerJS. Read more about migrating tests: https://git.io/ng-material-v9-hammer-migrate-tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125380620
Now this one, which should bring us to version 9 of Angular.
`NG_DISABLE_VERSION_CHECK=1 npx @angular/cli@9 update @angular/core@9 @angular/cli@9 -C --force`
We also need to do this:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1126521127
Let's test the upgrade from Angular 8.2 to Angular 9.1.
- [x] `npm install` works
- [x] `npm rm type:check:watch` shows 0 TypeScript errors
- [x] `npm run lint` runs and passes `All files pass linting.`
- [x] `npm run build` works
- [x] `npm start` works, with 0 errors in the browser console.
- [x] `npm run test` runs and passes.
`npm start` works as expected, and recognizes our proxy config in `proxy.conf.json`.
<img width="697" alt="Screen Shot 2022-05-13 at 1 32 51 PM" src="https://user-images.githubusercontent.com/2119400/168385373-dfcf2eae-ef18-40e6-8af5-5dccaa6e532a.png">
Helix UI renders with 0 errors and 1 warning in the browser console. The warning is understandable since the piwik telemetry library is not configured.
`npm run test` results
<img width="742" alt="Screen Shot 2022-05-13 at 2 24 31 PM" src="https://user-images.githubusercontent.com/2119400/168391523-849c115a-b2ea-4d44-bd15-32680af480e6.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125372983
Angular CLI version | Angular version | Node.js version | TypeScript version | RxJS version
-- | -- | -- | -- | --
~9.1.15 | ~9.1.13 | ^10.13.0 \|\| ^12.11.1 | >= 3.6.5 <= 3.8.3 | ^6.5.5
https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125480488
a few new peer dep warnings:
```py
ngx-vis@3.1.0 requires vis-data@^6.5.1
ngx-vis@3.1.0 requires vis-util@^4.0.0
vis-network@7.10.2 requires @egjs/hammerjs@^2.0.0
vis-network@7.10.2 requires component-emitter@^1.3.0
vis-network@7.10.2 requires uuid@^3.4.0 || ^7.0.0 || ^8.0.0
vis-network@7.10.2 requires vis-data@^6.2.1
vis-network@7.10.2 requires vis-util@^3.0.0 || ^4.0.0
vis-timeline@7.5.1 requires @egjs/hammerjs@^2.0.0
vis-timeline@7.5.1 requires component-emitter@^1.3.0
vis-timeline@7.5.1 requires keycharm@^0.3.0 || ^0.4.0
vis-timeline@7.5.1 requires uuid@^3.4.0 || ^7.0.0 || ^8.0.0
vis-timeline@7.5.1 requires vis-data@^6.3.0 || ^7.0.0
vis-timeline@7.5.1 requires vis-util@^3.0.0 || ^4.0.0 || ^5.0.0
vis-timeline@7.5.1 requires xss@^1.0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on issue #2092: upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on issue #2092:
URL: https://github.com/apache/helix/issues/2092#issuecomment-1125491837
Actually, let's try this instead:
```py
npm i ngx-vis@2.3.2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org