[jira] [Comment Edited] (BEAM-9709) timezone off by 8 hours

["Yueyang Qiu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-9709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082672#comment-17082672 ] 

Yueyang Qiu edited comment on BEAM-9709 at 4/13/20, 9:35 PM:
-------------------------------------------------------------

The cause of this issue is related to setting default time zone. ZetaSQL allows each engine to define its own default time zone. If the default time zone is UTC, then `2014-01-31 00:00:00+00` is the expected result, otherwise the current result could also be valid. This fails in compliance tests currently because in the harness we have not implemented this properly yet.


was (Author: robinyqiu):
The cause of this issue is related to setting default time zone. ZetaSQL allows each engine to define its own default time zone. If the default time zone is UTC, then `2014-01-31 00:00:00+00` is the expected result, otherwise the current result could also be valid. This fails in compliance tests currently because in the harness we have not implemented this properly yet ([https://cs.corp.google.com/piper///depot/google3/third_party/cloud_dataflow/sql/ExecuteQueryServiceServer.java?type=cs&q=SetDefaultTimeZone+file:%5E//depot/google3/third_party/cloud_dataflow/sql/+package:%5Epiper$&g=0&l=515]).

> timezone off by 8 hours
> -----------------------
>
>                 Key: BEAM-9709
>                 URL: https://issues.apache.org/jira/browse/BEAM-9709
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql-zetasql
>            Reporter: Andrew Pilloud
>            Assignee: Yueyang Qiu
>            Priority: Trivial
>              Labels: zetasql-compliance
>
> two failures in shard 13, one failure in shard 19
> {code}
> Expected: ARRAY<STRUCT<TIMESTAMP>>[{2014-01-31 00:00:00+00}]
>   Actual: ARRAY<STRUCT<$col1 TIMESTAMP>>[{2014-01-31 08:00:00+00}], 
> {code}
> {code}
> select timestamp(date '2014-01-31')
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)