You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/13 05:57:48 UTC

[GitHub] [incubator-kvrocks] tisonkun edited a comment on the discussion: Only saying 'closes #issue' in PR is not enough

GitHub user tisonkun edited a comment on the discussion: Only saying 'closes #issue' in PR is not enough

@ShooterIT If you find a specific PR without sufficient information/description, you as a committer can send a request changes review.

For some trivial changes like fix a typo or finish a subtasks whose tracking issue is clear defined (migrating tests, fixing clang-clippy linter), it needs not redundant description.

The GitHub-provided PULL_REQUEST_TEMPLATE mechanism can always grow too cumbersome to follow. I don't see a good practice for it - finally, most contributors omit it. (If it can support form like issue template, the case may be better, but not today.)

GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179#discussioncomment-4386296

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org