[GitHub] oschaaf commented on issue #1797: Document scope of TestingCoreFilters

[GitBox <gi...@apache.org>]

oschaaf commented on issue #1797: Document scope of TestingCoreFilters
URL: https://github.com/apache/incubator-pagespeed-mod/issues/1797#issuecomment-423115509
 
 
   I think this is relevant in the code, from https://github.com/apache/incubator-pagespeed-mod/blob/b4bf44cc56d8bbf17494c540dfb6ef20dfcf5073/net/instaweb/rewriter/rewrite_options.cc#L640
   
   ```c++
   // Note: all Core filters are Test filters as well.  For maintainability,
   // this is managed in the c++ switch statement.
   const RewriteOptions::Filter kTestFilterSet[] = {
       RewriteOptions::kConvertJpegToWebp,
       RewriteOptions::kDebug,
       RewriteOptions::kDeferIframe,
       RewriteOptions::kDeferJavascript,
       RewriteOptions::kDelayImages,  // AKA inline_preview_images
       RewriteOptions::kIncludeJsSourceMaps,
       RewriteOptions::kInsertAmpLink,
       RewriteOptions::kInsertGA,
       RewriteOptions::kInsertImageDimensions,
       RewriteOptions::kLazyloadImages,
       RewriteOptions::kLeftTrimUrls,
       RewriteOptions::kMakeGoogleAnalyticsAsync,
       RewriteOptions::kPrioritizeCriticalCss,
       RewriteOptions::kResizeToRenderedImageDimensions,
       RewriteOptions::kResponsiveImages,
       RewriteOptions::kRewriteDomains,
       RewriteOptions::kSpriteImages,
   };
   ```
   
   Doc pull requests welcome! :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services