You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/30 19:17:04 UTC

[GitHub] [incubator-tvm] mwillsey commented on pull request #6563: [Rust] Improve NDArray, GraphRt, and Relay bindings

mwillsey commented on pull request #6563:
URL: https://github.com/apache/incubator-tvm/pull/6563#issuecomment-701591004


   @imalsogreg @jroesch Just to break this out into a comment. Many of the remaining issues on this PR that @imalsogreg commented on stem from the fact that `NDArray` (and `NDArrayContainer`) hide the type of the underlying data. This means that typed conversions must be given the type, and we basically have no choice but to trust it.
   
   Should we block this PR on fixing this? I'm leaning toward no. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org