[jira] Commented: (HBASE-1717) Put on client-side uses passed-in byte[]s rather than always using copies

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736247#action_12736247 ] 

stack commented on HBASE-1717:
------------------------------

+1 on getting fresh instance of family to add to familymap but -1 on cloning KV.  KV is immutable.  If client makes KVs backed by a byte array of their own construction and then reuse,  then they will have issue.  You suggest javadoc'ing... That seems good to me.

> Put on client-side uses passed-in byte[]s rather than always using copies
> -------------------------------------------------------------------------
>
>                 Key: HBASE-1717
>                 URL: https://issues.apache.org/jira/browse/HBASE-1717
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1717-v1.patch, HBASE-1717-v2.patch
>
>
> During review of Put with ryan, found that we are using a passed in reference to family in add() rather than a local copy.  If the backing array changed values, this could cause trouble.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.