[jira] [Commented] (KARAF-6319) Add allowing to define the early stage boot features

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616769#comment-17616769 ] 

ASF GitHub Bot commented on KARAF-6319:
---------------------------------------

jbonofre commented on code in PR #1649:
URL: https://github.com/apache/karaf/pull/1649#discussion_r994097147


##########
manual/src/main/asciidoc/developer-guide/karaf-maven-plugin.adoc:
##########
@@ -471,6 +471,9 @@ The `karaf:assembly` goal creates a Karaf instance (assembly) filesystem using t
                     <installedBundles>
                         <installedBundle>${additional.bundle}</installedBundle>
                     </installedBundles>
+                    <prerequisiteFeatures>
+                        <feature>ssh</feature>

Review Comment:
   Are you sure about `prerequisiteFeature` name ? Maybe it's a bit confusing for users as `prerequisite` is also a flag in features repository XML.
   That's why my first idea was to use `firstStageBootFeature`, to represent it's a boot feature but in "first" stage.





> Add <stageBootFeatures/> allowing to define the early stage boot features
> -------------------------------------------------------------------------
>
>                 Key: KARAF-6319
>                 URL: https://issues.apache.org/jira/browse/KARAF-6319
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>
> Right now, using the {{karaf:assembly}} goal, we can provide the {{<bootFeatures/>}}, ending in {{featuresBoot}} property in {{etc/org.apache.karaf.features.cfg}}.
> However, it's not possible during the assembly to specify the "early" stage boot features, for instance, something like:
> {code}
> featuresBoot=(instance,package,log,ssh,framework,feature),myfeature
> {code}
> I'm proposing to add (in the {{Builder}}) a {{<firstBootFeatures/>}} that will be adding in the early stage, before the "regular" {{<bootFeatures/>}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)