You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <re...@gmail.com> on 2013/07/05 22:57:18 UTC

Review Request 12282: Reduce standard header size to

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12282/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Lots of <h2> on a single page draws too much attention to the headers.


Diffs
-----

  src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110 
  src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 
  src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 
  src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8 
  src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d 
  src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014 
  src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be 
  src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c 

Diff: https://reviews.apache.org/r/12282/diff/


Testing
-------


Thanks,

Ross Allen


Re: Review Request 12282: Reduce standard header size to

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12282/#review22822
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 5, 2013, 10:54 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12282/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 10:54 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Lots of <h2> on a single page draws too much attention to the headers.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110 
>   src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 
>   src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 
>   src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8 
>   src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d 
>   src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014 
>   src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be 
>   src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c 
> 
> Diff: https://reviews.apache.org/r/12282/diff/
> 
> 
> Testing
> -------
> 
> Viewed all pages with header changes. Headers still render fine but with a slightly smaller font-size.
> 
> 
> Thanks,
> 
> Ross Allen
> 
>


Re: Review Request 12282: Reduce standard header size to

Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12282/
-----------------------------------------------------------

(Updated July 5, 2013, 10:54 p.m.)


Review request for mesos.


Repository: mesos


Description
-------

Lots of <h2> on a single page draws too much attention to the headers.


Diffs
-----

  src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110 
  src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 
  src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 
  src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8 
  src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d 
  src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014 
  src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be 
  src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c 

Diff: https://reviews.apache.org/r/12282/diff/


Testing (updated)
-------

Viewed all pages with header changes. Headers still render fine but with a slightly smaller font-size.


Thanks,

Ross Allen