You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/06 17:29:52 UTC

[GitHub] Roshrini commented on a change in pull request #12010: Adjusting tolerance level and removing fixed seed for tests: test_ifft, test_fft

Roshrini commented on a change in pull request #12010: Adjusting tolerance level and removing fixed seed for tests: test_ifft, test_fft
URL: https://github.com/apache/incubator-mxnet/pull/12010#discussion_r207970502
 
 

 ##########
 File path: tests/python/gpu/test_operator_gpu.py
 ##########
 @@ -251,9 +253,11 @@ def check_fft(shape):
         for exe in exe_list:
             exe.backward([out_grad])
         a = np.fft.ifft(out_grad_complex, n=None, axis=-1, norm=None)
-        assert_almost_equal(a.real, exe.grad_arrays[0].asnumpy()/shape[3],rtol=1e-3, atol=1e-6)
+        assert_almost_equal(a.real, exe.grad_arrays[0].asnumpy()/shape[3],rtol=1e-3, atol=1e-5)
 
-@with_seed(0)
+# @roshrini - removing fixed seed for this test. raised tolerance level.
+# Issue to track: https://github.com/apache/incubator-mxnet/issues/11730
 
 Review comment:
   Removed comments. Issues are already linked in this PR description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services