You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/05 15:30:22 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1911: Add Bulk import to randomwalk MultiTable

ctubbsii commented on a change in pull request #1911:
URL: https://github.com/apache/accumulo/pull/1911#discussion_r571049646



##########
File path: test/system/randomwalk/conf/modules/MultiTable.xml
##########
@@ -29,11 +29,11 @@
 
 <node id="dummy.ToAll">
   <edge id="mt.CreateTable" weight="20"/>
-  <edge id="mt.Write" weight="100"/>
+  <edge id="mt.Write" weight="10"/>
   <edge id="mt.CopyTable" weight="5"/>
+  <edge id="mt.BulkImport" weight="100"/>
   <edge id="mt.OfflineTable" weight="10"/>
   <edge id="mt.DropTable" weight="3"/>
-  <edge id="END" weight="1"/>

Review comment:
       Should this be kept?

##########
File path: test/system/randomwalk/conf/modules/MultiTable.xml
##########
@@ -29,11 +29,11 @@
 
 <node id="dummy.ToAll">
   <edge id="mt.CreateTable" weight="20"/>
-  <edge id="mt.Write" weight="100"/>
+  <edge id="mt.Write" weight="10"/>
   <edge id="mt.CopyTable" weight="5"/>
+  <edge id="mt.BulkImport" weight="100"/>

Review comment:
       Do these relative weights make sense as default or were they just what you were using to test?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org