You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/24 03:35:29 UTC

[GitHub] [flink] LadyForest opened a new pull request, #21134: [FLINK-29677] Prevent dropping the current catalog

LadyForest opened a new pull request, #21134:
URL: https://github.com/apache/flink/pull/21134

   ## What is the purpose of the change
   
   This pull request fixes the issue that when dropping a catalog in use, the following SHOW CURRENT CATALOG still displays the dropped catalog by preventing users from dropping a catalog in use.
   
   ## Brief change log
   
   Let CatalogManager#unregisterCatalog throws CatalogException when dropping a catalog in use.
   
   
   ## Verifying this change
   
   This change is a trivial rework and can be verified as follows:
   
   - `CatalogITCase#testDropCatalog`
   - `TableEnvironmentTest#testExecuteSqlWithCreateUseDropCatalog`
   - `catalog_database.q` which executed by `ClientITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduces a new feature? no
     - If yes, how is the feature documented? not applicable 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 merged pull request #21134: [FLINK-29677] Prevent dropping the current catalog

Posted by GitBox <gi...@apache.org>.
fsk119 merged PR #21134:
URL: https://github.com/apache/flink/pull/21134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21134: [FLINK-29677] Prevent dropping the current catalog

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21134:
URL: https://github.com/apache/flink/pull/21134#issuecomment-1288372336

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e637df006f28bfd7c27b570561b43c0a7c0f015f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e637df006f28bfd7c27b570561b43c0a7c0f015f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e637df006f28bfd7c27b570561b43c0a7c0f015f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org