You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2023/05/14 06:55:34 UTC

[GitHub] [ozone] szetszwo opened a new pull request, #4710: HDDS-8621. IOException is never thrown in SCMRatisServer.getRatisRoles().

szetszwo opened a new pull request, #4710:
URL: https://github.com/apache/ozone/pull/4710

   ## What changes were proposed in this pull request?
   
   - Remove `throws IOException` from `SCMRatisServer.getRatisRoles()` and the related method.
   - Add `getName()` and `getBaseDir()` to `MiniOzoneCluster`.
   - Update `TestMiniOzoneCluster` to junit 5.
   
   ## What is the link to the Apache JIRA
   
   HDDS-8621
   
   ## How was this patch tested?
   
   Add new asserts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #4710: HDDS-8621. IOException is never thrown in SCMRatisServer.getRatisRoles().

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4710:
URL: https://github.com/apache/ozone/pull/4710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #4710: HDDS-8621. IOException is never thrown in SCMRatisServer.getRatisRoles().

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4710:
URL: https://github.com/apache/ozone/pull/4710#issuecomment-1546895779

   Thanks @szetszwo for the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] szetszwo commented on pull request #4710: HDDS-8621. IOException is never thrown in SCMRatisServer.getRatisRoles().

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #4710:
URL: https://github.com/apache/ozone/pull/4710#issuecomment-1546904952

   @adoroszlai , thanks a lot for reviewing and merging this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org