You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/06 16:52:17 UTC

[GitHub] [arrow] trxcllnt commented on pull request #11655: ARROW-14647: [JS] fix bignumToNumber for negative numbers

trxcllnt commented on PR #11655:
URL: https://github.com/apache/arrow/pull/11655#issuecomment-1090488369

   @domoritz shifting 64 vs. 32 bits will be slower, but seems like the price of correctness. I don't think we capture this in the current performance tests. Looking at the implementation, I'm not sure it could be much faster. Maybe swapping out the `for (word of words)` iterator for a numeric index counting loop, but seems minor. I vote we merge this as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org