You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by madrob <gi...@git.apache.org> on 2014/07/31 23:25:47 UTC
[GitHub] curator pull request: CURATOR-131 use iterator.remove instead of f...
GitHub user madrob opened a pull request:
https://github.com/apache/curator/pull/29
CURATOR-131 use iterator.remove instead of foreach
When iterating over a collection, if we try to remove elements that
can lead to undefined behaviour. We should use an iterator and its
remove method to do this safely.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madrob/curator CURATOR-131
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit e38d1ceda492e097ad9c94bb854838f2b1f7caa9
Author: Mike Drob <md...@cloudera.com>
Date: 2014-07-31T21:24:40Z
CURATOR-131 use iterator.remove instead of foreach
When iterating over a collection, if we try to remove elements that
can lead to undefined behaviour. We should use an iterator and its
remove method to do this safely.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-131 use iterator.remove instead of f...
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/29#issuecomment-51744543
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-131 use iterator.remove instead of f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---