You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2023/05/09 13:40:14 UTC

[GitHub] [camel] apupier commented on a diff in pull request #9987: CAMEL-19313: resolve option placeholder

apupier commented on code in PR #9987:
URL: https://github.com/apache/camel/pull/9987#discussion_r1188617909


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/CamelCommand.java:
##########
@@ -67,9 +68,28 @@ public Integer call() throws Exception {
             configureLoggingOff();
         }
 
+        replacePlaceholders();
+
         return doCall();
     }
 
+    private void replacePlaceholders() throws Exception {
+        for (CommandLine.Model.ArgSpec argSpec : spec.args()) {
+            String defaultValue = spec.defaultValueProvider().defaultValue(argSpec);

Review Comment:
   the default values are the values set in configuration? (like when set with `jbang camel@apache/camel config set repos=https://maven.repository.redhat.com/ga`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org